From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Waitz Subject: [PATCH] gitweb: fix project list if PATH_INFO=="/". Date: Thu, 17 Aug 2006 00:28:40 +0200 Message-ID: <11557673262714-git-send-email-tali@admingilde.org> References: <11557673213372-git-send-email-tali@admingilde.org> <11557673212235-git-send-email-tali@admingilde.org> <1155767325181-git-send-email-tali@admingilde.org> <11557673263081-git-send-email-tali@admingilde.org> Cc: Martin Waitz X-From: git-owner@vger.kernel.org Thu Aug 17 00:29:19 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GDTsq-0000AM-Fg for gcvg-git@gmane.org; Thu, 17 Aug 2006 00:29:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932296AbWHPW2u (ORCPT ); Wed, 16 Aug 2006 18:28:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932300AbWHPW2u (ORCPT ); Wed, 16 Aug 2006 18:28:50 -0400 Received: from agent.admingilde.org ([213.95.21.5]:13256 "EHLO mail.admingilde.org") by vger.kernel.org with ESMTP id S932296AbWHPW2t (ORCPT ); Wed, 16 Aug 2006 18:28:49 -0400 Received: from martin by mail.admingilde.org with local (Exim 4.50 #1) id 1GDTsU-0007Ob-Rb; Thu, 17 Aug 2006 00:28:47 +0200 To: git@vger.kernel.org X-Mailer: git-send-email 1.4.2.rc2.gf055 In-Reply-To: <11557673263081-git-send-email-tali@admingilde.org> Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: The project list now uses several common header / footer generation functions. These functions only check for "defined $project", but when PATH_INFO just contains a "/" (which is often generated by web servers), then this test fails. Now explicitly undef $project if there is none so that the tests in other gitweb parts work again. Signed-off-by: Martin Waitz --- gitweb/gitweb.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 0a0b37f..3b6333c 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -100,8 +100,9 @@ our $project = ($cgi->param('p') || $ENV if (defined $project) { $project =~ s|^/||; $project =~ s|/$||; + $project = undef unless $project; } -if (defined $project && $project) { +if (defined $project) { if (!validate_input($project)) { die_error(undef, "Invalid project parameter"); } -- 1.4.2.rc2.gf055