git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH 5/7] gitweb: Use 'local $/ = undef;' before 'print <$fd>;'
Date: Sat, 26 Aug 2006 19:14:24 +0200	[thread overview]
Message-ID: <11566124673653-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <1156612392716-git-send-email-jnareb@gmail.com>

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 093deab..eae83e6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2017,6 +2017,7 @@ sub git_project_list {
 	if (-f $home_text) {
 		print "<div class=\"index_include\">\n";
 		open (my $fd, $home_text);
+		local $/ = undef;
 		print <$fd>;
 		close $fd;
 		print "</div>\n";
@@ -2395,11 +2396,10 @@ sub git_blob_plain {
 
 	print $cgi->header(-type => "$type",
 	                   -content_disposition => "inline; filename=\"$save_as\"");
-	undef $/;
 	binmode STDOUT, ':raw';
+	local $/ = undef;
 	print <$fd>;
 	binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
-	$/ = "\n";
 	close $fd;
 }
 
@@ -2585,6 +2585,7 @@ sub git_snapshot {
 	open my $fd, "-|", "$GIT tar-tree $hash \'$project\' | $command" or
 		die_error(undef, "Execute git-tar-tree failed.");
 	binmode STDOUT, ':raw';
+	local $/ = undef;
 	print <$fd>;
 	binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
 	close $fd;
-- 
1.4.1.1

  parent reply	other threads:[~2006-08-26 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-26 17:13 [PATCH 0/7] gitweb: Cleanups, fixes and small improvements Jakub Narebski
2006-08-26 17:14 ` [PATCH 1/7] gitweb: Restore old git_blame using git-annotate under "annotate" Jakub Narebski
2006-08-26 17:14 ` [PATCH 2/7] gitweb: Remove workaround for git-diff bug fixed in f82cd3c Jakub Narebski
2006-08-26 17:14 ` [PATCH 3/7] gitweb: Improve comments about gitweb features configuration Jakub Narebski
2006-08-26 17:14 ` [PATCH 4/7] gitweb: Fix typo in git_patchset_body Jakub Narebski
2006-08-26 17:14 ` Jakub Narebski [this message]
2006-08-26 17:14 ` [PATCH 6/7] gitweb: blobs defined by non-textual hash ids can be cached Jakub Narebski
2006-08-26 17:14 ` [PATCH 7/7] gitweb: Always link to plain version of the blob in git_blob Jakub Narebski
2006-08-26 20:58 ` [PATCH 0/7] gitweb: Cleanups, fixes and small improvements Junio C Hamano
2006-08-26 21:18   ` Jakub Narebski
2006-08-27 20:21   ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11566124673653-git-send-email-jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).