From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Linus Torvalds <torvalds@osdl.org>, Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH] gitweb: Add local time and timezone to git_print_authorship
Date: Mon, 28 Aug 2006 23:17:31 +0200 [thread overview]
Message-ID: <11567998513000-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0608281016380.27779@g5.osdl.org>
Linus Torvalds wrote:
> I've got _one_ small beef with gitweb still, which is that it seems to
> like always showing things in UTC rather than the "native" timezone, but I
> can see why people would sometimes want that. So I'm not actually sure
> it's wrong.
>
> I think it _may_ be worth showing the native timezone in the "commit-diff"
> view (when you see only one commit), and then show the UTC time in the
> "log" view (when you see a lot of commits, and might want to compare times
> in different timezones more easily).
>
> But I think that timezone thing is probably a matter of taste rather than
> much anything else.
-- >8 --
Add local time (hours and minutes) and local timezone to the output of
git_print_authorship command, used by git_commitdiff. The code was
taken from git_commit subroutine.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
gitweb/gitweb.perl | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ef09cf5..fa7f62a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1345,10 +1345,18 @@ #sub git_print_authorship (\%) {
sub git_print_authorship {
my $co = shift;
- my %ad = parse_date($co->{'author_epoch'});
+ my %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});
print "<div class=\"author_date\">" .
esc_html($co->{'author_name'}) .
- " [$ad{'rfc2822'}]</div>\n";
+ " [$ad{'rfc2822'}";
+ if ($ad{'hour_local'} < 6) {
+ printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
+ $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'});
+ } else {
+ printf(" (%02d:%02d %s)",
+ $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'});
+ }
+ print "]</div>\n";
}
sub git_print_page_path {
--
1.4.1.1
next prev parent reply other threads:[~2006-08-28 21:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 12:48 [PATCH 0/5] gitweb: Additions to commitdiff view Jakub Narebski
2006-08-28 12:48 ` [PATCH 1/5] gitweb: Make git_print_log generic; git_print_simplified_log uses it Jakub Narebski
2006-08-28 12:48 ` [PATCH 2/5] gitweb: Do not remove signoff lines in git_print_simplified_log Jakub Narebski
2006-08-28 12:48 ` [PATCH 3/5] gitweb: Add author information to commitdiff view Jakub Narebski
2006-08-28 12:48 ` [PATCH 4/5] gitweb: git_print_log: signoff line is non-empty line Jakub Narebski
2006-08-28 12:48 ` [PATCH 5/5] gitweb: Add diff tree, with links to patches, to commitdiff view Jakub Narebski
2006-08-28 17:26 ` [PATCH 0/5] gitweb: Additions " Linus Torvalds
2006-08-28 21:17 ` Jakub Narebski [this message]
2006-08-29 0:16 ` [PATCH] gitweb: Add local time and timezone to git_print_authorship Junio C Hamano
2006-08-29 8:23 ` Jakub Narebski
2006-08-29 9:05 ` Junio C Hamano
2006-08-29 10:15 ` Jakub Narebski
2006-08-30 4:26 ` Junio C Hamano
2006-08-30 9:47 ` Jakub Narebski
2006-08-29 9:06 ` [PATCH] gitweb: split output routine of blame2 Junio C Hamano
2006-08-29 9:06 ` [PATCH] gitweb: show rev only on the first line of each group in blame Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11567998513000-git-send-email-jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).