ab/ci-setup-simplify (was Re: What's cooking in git.git (Apr 2022, #05; Mon, 18))

[Phillip Wood <phillip.wood123@gmail.com>]

> * ab/ci-setup-simplify (2022-04-14) 29 commits
>   - CI: make it easy to use ci/*.sh outside of CI
>   - CI: don't use "set -x" in "ci/lib.sh" output
>   - CI: set PYTHON_PATH setting for osx-{clang,gcc} into "$jobname" case
>   - CI: set SANITIZE=leak in MAKEFLAGS directly
>   - CI: set CC in MAKEFLAGS directly, don't add it to the environment
>   - CI: add more variables to MAKEFLAGS, except under vs-build
>   - CI: narrow down variable definitions in --build and --test
>   - CI: only invoke ci/lib.sh as "steps" in main.yml
>   - CI: pre-select test slice in Windows & VS tests
>   - ci/run-test-slice.sh: replace shelling out with "echo"
>   - CI: move "env" definitions into ci/lib.sh
>   - CI: combine ci/install{,-docker}-dependencies.sh
>   - CI: split up and reduce "ci/test-documentation.sh"
>   - CI: invoke "make artifacts-tar" directly in windows-build
>   - CI: check ignored unignored build artifacts in "win[+VS] build" too
>   - ci/lib.sh: use "test" instead of "["
>   - CI: remove "run-build-and-tests.sh", run "make [test]" directly
>   - CI: export variables via a wrapper
>   - CI: consistently use "export" in ci/lib.sh
>   - CI: move p4 and git-lfs variables to ci/install-dependencies.sh
>   - CI: have "static-analysis" run "check-builtins", not "documentation"
>   - CI: have "static-analysis" run a "make ci-static-analysis" target
>   - CI: don't have "git grep" invoke a pager in tree content check
>   - CI/lib.sh: stop adding leading whitespace to $MAKEFLAGS
>   - CI: remove unused Azure ci/* code
>   - CI: remove dead "tree skipping" code
>   - CI: remove more dead Travis CI support
>   - CI: make "$jobname" explicit, remove fallback
>   - CI: run "set -ex" early in ci/lib.sh
>   (this branch is used by ab/ci-github-workflow-markup.)
> 
>   Drive more actions done in CI via the Makefile instead of shell
>   commands sprinkled in .github/workflows/main.yml
> 
>   Will merge to 'next'?
>   source: <cover-v3-00.29-00000000000-20220413T194847Z-avarab@gmail.com>

I haven't had time to read all 31 patches from v4 in detail but I have 
looked at the results in seen.

Looking at seen:ci/install-dependencies.sh the shebang has been changed 
to "#!/bin/sh" but it contains "BREW_PACKAGE=${CC_PACKAGE/-/@}" which is 
a bashism.

Looking at seen:.github/workflows/main.yaml to skip running the tests 
one has to set "skip-tests: no" which is utterly confusing.

 From what I saw scanning the patches there seemed to be a lot of churn, 
both of existing code and code that gets added and then moved/refactored 
within the series.

Looking at the output of a recent ci run of seen the steps to prepare 
the environment before building and testing print all the environment 
variables rather than just the ones being set for that step which seems 
to go against the aim of "CI: narrow down variable definitions in 
--build and --test". (Also the "SKIP" prefix in the output lacks a ":")

Dscho raised concerns that this removes any support for azure pipelines 
which he uses when preparing security patches.

I think splitting out the build and test steps is a good idea but I'm 
less convinced by some of the other changes.

Best Wishes

Phillip