From: asf@boinkor.net
To: git@vger.kernel.org
Cc: Andreas Fuchs <asf@boinkor.net>
Subject: [PATCH] gitweb: Make RSS feed output prettier
Date: Wed, 15 Nov 2006 01:10:36 +0100 [thread overview]
Message-ID: <11635494363452-git-send-email-asf@boinkor.net> (raw)
From: Andreas Fuchs <asf@boinkor.net>
* Wrap the commit message in <pre>
* Make file names into an unordered list
* Add links (diff, conditional blame, history) to the file list.
---
gitweb/gitweb.perl | 22 ++++++++++++++++------
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index e54a29e..2a79895 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4134,20 +4134,30 @@ XML
"<content:encoded>" .
"<![CDATA[\n";
my $comment = $co{'comment'};
+ print "<pre>\n";
foreach my $line (@$comment) {
- $line = to_utf8($line);
- print "$line<br/>\n";
+ $line = to_utf8(esc_html($line));
+ print "$line\n";
}
- print "<br/>\n";
+ print "</pre><ul>\n";
foreach my $line (@difftree) {
if (!($line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40}) ([0-9a-fA-F]{40}) (.)([0-9]{0,3})\t(.*)$/)) {
next;
}
- my $file = esc_path(unquote($7));
+ my $file_name = unquote($7);
+ my $file = esc_html($file_name);
+ my $parent = $co{'parent'};
+ my $hash = git_get_hash_by_path($commit, $file_name);
+ my $hashparent = git_get_hash_by_path($parent, $file_name);
+
$file = to_utf8($file);
- print "$file<br/>\n";
+ print "<li>$file ";
+ print "[<a href=\"". esc_html("$my_url?p=$project;a=blobdiff;f=$file;h=$hash;hp=$hashparent;hb=$commit;hpb=$parent") ."\">diff</a>] ";
+ print "[<a href=\"". esc_html("$my_url?p=$project;a=blame;f=$file;hb=$commit") ."\">blame</a>] " if gitweb_check_feature('blame');
+ print "[<a href=\"". esc_html("$my_url?p=$project;a=history;f=$file;h=$commit") ."\">history</a>] ";
+ print "</li>\n";
}
- print "]]>\n" .
+ print "</ul>]]>\n" .
"</content:encoded>\n" .
"</item>\n";
}
--
1.4.3.2
next reply other threads:[~2006-11-15 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 0:10 asf [this message]
2006-11-15 0:24 ` [PATCH] gitweb: Make RSS feed output prettier Jakub Narebski
2006-11-16 21:45 ` [PATCH] gitweb: Atom feeds (was: gitweb: Make RSS feed output prettier) Andreas Fuchs
2006-11-17 9:01 ` [PATCH] gitweb: Atom feeds Junio C Hamano
2006-11-17 11:36 ` Jakub Narebski
2006-11-19 14:05 ` [PATCH 1/2] gitweb: Add an option to href() to return full URL Jakub Narebski
2006-11-19 14:05 ` [PATCH 2/2] gitweb: Refactor feed generation, make output prettier, add Atom feed Jakub Narebski
2006-11-20 14:45 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11635494363452-git-send-email-asf@boinkor.net \
--to=asf@boinkor.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).