From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH 5/5] gitweb: Add an option to href() to return full URL
Date: Sat, 18 Nov 2006 23:35:42 +0100 [thread overview]
Message-ID: <1163889347230-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <1163889342877-git-send-email-jnareb@gmail.com>
href subroutine by default generates absolute URL (generated using
CGI::url(-absolute=>1), and saved in $my_uri) using $my_uri as base;
add an option to generate full URL using $my_url as base.
New feature usage: href(..., -full=>1)
To be used in web feeds (RSS, Atom, OPML) and other places which need
full URL rather than absolute or relative.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
gitweb/gitweb.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5875ba0..8739501 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -459,7 +459,8 @@ exit;
sub href(%) {
my %params = @_;
- my $href = $my_uri;
+ # default is to use -absolute url() i.e. $my_uri
+ my $href = $params{-full} ? $my_url : $my_uri;
# XXX: Warning: If you touch this, check the search form for updating,
# too.
--
1.4.3.4
prev parent reply other threads:[~2006-11-18 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 22:35 [PATCH 0/5] gitweb: New patchset view corrections and improvements, and few other things Jakub Narebski
2006-11-18 22:35 ` [PATCH 1/5] gitweb: Protect against possible warning in git_commitdiff Jakub Narebski
2006-11-18 22:38 ` Jakub Narebski
2006-11-18 22:35 ` [PATCH 2/5] gitweb: Buffer diff header to deal with split patches + git_patchset_body refactoring Jakub Narebski
2006-11-18 22:35 ` [PATCH 3/5] gitweb: New improved formatting of chunk header in diff Jakub Narebski
2006-11-18 22:35 ` [PATCH 4/5] gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" Jakub Narebski
2006-11-18 22:35 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163889347230-git-send-email-jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).