git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Josh Soref via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Josh Soref <jsoref@gmail.com>,
	Josh Soref <jsoref@gmail.com>
Subject: [PATCH 5/8] SubmittingPatches: improve extra tags advice
Date: Tue, 19 Dec 2023 08:41:56 +0000	[thread overview]
Message-ID: <11688e4360c1698e56b3485e3df4e171397d3c3c.1702975320.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1623.git.1702975319.gitgitgadget@gmail.com>

From: Josh Soref <jsoref@gmail.com>

Current statistics show a strong preference to only capitalize the first
letter in a hyphenated tag, but that some guidance would be helpful:

git log |
  perl -ne 'next unless /^\s+(?:Signed-[oO]ff|Acked)-[bB]y:/;
    s/^\s+//;s/:.*/:/;print'|
  sort|uniq -c|sort -n
   2 Signed-off-By:
   4 Signed-Off-by:
  22 Acked-By:
  47 Signed-Off-By:
2202 Acked-by:
95315 Signed-off-by:

Signed-off-by: Josh Soref <jsoref@gmail.com>
---
 Documentation/SubmittingPatches | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 694a7bafb68..d7a84f59478 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -369,6 +369,9 @@ If you like, you can put extra tags at the end:
 You can also create your own tag or use one that's in common usage
 such as "Thanks-to:", "Based-on-patch-by:", or "Improved-by:".
 
+Extra tags should only capitalize the very first letter, i.e. favor
+"Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By".
+
 [[git-tools]]
 === Generate your patch using Git tools out of your commits.
 
-- 
gitgitgadget


  parent reply	other threads:[~2023-12-19  8:42 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  8:41 [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 1/8] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 2/8] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 3/8] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 4/8] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-20 15:18   ` Phillip Wood
2023-12-20 15:30     ` Elijah Newren
2023-12-20 16:09       ` Josh Soref
2023-12-20 16:49         ` Elijah Newren
2023-12-20 17:42           ` Josh Soref
2023-12-21 15:09             ` phillip.wood123
2023-12-20 16:31     ` Junio C Hamano
2023-12-19  8:41 ` Josh Soref via GitGitGadget [this message]
2023-12-19  8:41 ` [PATCH 6/8] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-19 14:44   ` René Scharfe
2023-12-20 15:40     ` Elijah Newren
2023-12-20 16:25       ` Josh Soref
2023-12-20 16:39       ` Junio C Hamano
2023-12-19  8:41 ` [PATCH 7/8] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-20 15:21   ` Elijah Newren
2023-12-20 16:16     ` Josh Soref
2023-12-20 17:00       ` Elijah Newren
2023-12-19  8:41 ` [PATCH 8/8] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-20 15:43 ` [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Elijah Newren
2023-12-21 16:40 ` [PATCH v2 0/9] " Josh Soref via GitGitGadget
2023-12-21 16:40   ` [PATCH v2 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-21 21:03     ` Junio C Hamano
2023-12-21 21:52       ` Josh Soref
2023-12-22  1:30       ` Dragan Simic
2023-12-21 16:40   ` [PATCH v2 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-21 20:57     ` Junio C Hamano
2023-12-21 21:46       ` Josh Soref
2023-12-21 21:57         ` Junio C Hamano
2023-12-21 16:40   ` [PATCH v2 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-21 21:09     ` Junio C Hamano
2023-12-21 16:41   ` [PATCH v2 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-21 16:41   ` [PATCH v2 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-21 21:16     ` Junio C Hamano
2023-12-21 21:55       ` Josh Soref
2023-12-21 16:41   ` [PATCH v2 6/9] SubmittingPatches: improve extra tags advice Josh Soref via GitGitGadget
2023-12-21 21:18     ` Junio C Hamano
2023-12-21 16:41   ` [PATCH v2 7/9] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-21 21:27     ` Junio C Hamano
2023-12-21 16:41   ` [PATCH v2 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-21 16:41   ` [PATCH v2 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-28  4:55   ` [PATCH v3 0/9] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 6/9] SubmittingPatches: provide tag naming advice Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 7/9] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11688e4360c1698e56b3485e3df4e171397d3c3c.1702975320.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jsoref@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).