From: rael@zopyra.com
To: git@vger.kernel.org
Cc: Bill Lear <rael@zopyra.com>
Subject: [PATCH] Document check option to git diff.
Date: Fri, 26 Jan 2007 11:42:52 -0600 [thread overview]
Message-ID: <1169833372823-git-send-email-rael@zopyra.com> (raw)
From: Bill Lear <rael@zopyra.com>
Signed-off-by: Bill Lear <rael@zopyra.com>
---
Documentation/SubmittingPatches | 3 ++-
Documentation/diff-options.txt | 5 +++++
Documentation/git-diff.txt | 6 ++++++
3 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 41b76d8..ce85d06 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -23,7 +23,8 @@ probably need to split up your commit to finer grained pieces.
Oh, another thing. I am picky about whitespaces. Make sure your
changes do not trigger errors with the sample pre-commit hook shipped
-in templates/hooks--pre-commit.
+in templates/hooks--pre-commit. To help ensure this does not happen,
+run git diff --check on your changes before you commit.
(2) Generate your patch using git tools out of your commits.
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index da1cc60..501e0df 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -58,6 +58,11 @@
Turn off rename detection, even when the configuration
file gives the default to do so.
+--check::
+ Check whether differences form a valid patch. Warns if
+ differences include a space before a tab or a space at the end
+ of a line.
+
--full-index::
Instead of the first handful characters, show full
object name of pre- and post-image blob on the "index"
diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt
index 6a098df..5054fb7 100644
--- a/Documentation/git-diff.txt
+++ b/Documentation/git-diff.txt
@@ -70,6 +70,7 @@ Various ways to check your working tree::
$ git diff <1>
$ git diff --cached <2>
$ git diff HEAD <3>
+$ git diff --check <4>
------------
+
<1> changes in the working tree not yet staged for the next commit.
@@ -77,6 +78,11 @@ $ git diff HEAD <3>
would be committing if you run "git commit" without "-a" option.
<3> changes in the working tree since your last commit; what you
would be committing if you run "git commit -a"
+<4> display whether what you are about to commit is a valid patch,
+including whether you have spaces at the end of lines, or spaces
+before tabs. Violations are displayed in this form:
+
+<file name>:<line number>:<violation>:<offending line>
Comparing with arbitrary commits::
+
--
1.5.0-rc2.GIT-dirty
next reply other threads:[~2007-01-26 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 17:42 rael [this message]
2007-01-26 23:46 ` [PATCH] Document check option to git diff Junio C Hamano
2007-01-27 2:06 ` Bill Lear
2007-01-27 3:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169833372823-git-send-email-rael@zopyra.com \
--to=rael@zopyra.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).