From: "Julian Phillips" <jp3@quantumfyre.co.uk>
To: git@vger.kernel.org
Cc: Julian Phillips <julian@quantumfyre.co.uk>
Subject: [PATCH] Allow fetch--tool to read from stdin
Date: Tue, 13 Feb 2007 01:21:39 +0000 [thread overview]
Message-ID: <11713297013179-git-send-email-julian@quantumfyre.co.uk> (raw)
In-Reply-To: <11713297014015-git-send-email-julian@quantumfyre.co.uk>
If the reflist is "-" then read the reflist data from stdin instead,
this will allow the passing of more than 128K of reflist data - which
won't fit in the environment passed by execve.
Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
---
builtin-fetch--tool.c | 24 ++++++++++++++++++++++--
1 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/builtin-fetch--tool.c b/builtin-fetch--tool.c
index 3090ffe..619ceb0 100644
--- a/builtin-fetch--tool.c
+++ b/builtin-fetch--tool.c
@@ -2,6 +2,20 @@
#include "refs.h"
#include "commit.h"
+static char *get_stdin(void)
+{
+#define CHUNK_SIZE (1048576)
+ char *data = xmalloc(CHUNK_SIZE);
+ int offset = 0, read = 0;
+ read = xread(0, data, CHUNK_SIZE);
+ while (read == CHUNK_SIZE) {
+ offset += CHUNK_SIZE;
+ data = xrealloc(data, offset + CHUNK_SIZE);
+ read = xread(0, data + offset, CHUNK_SIZE);
+ }
+ return data;
+}
+
static void show_new(char *type, unsigned char *sha1_new)
{
fprintf(stderr, " %s: %s\n", type,
@@ -463,12 +477,18 @@ int cmd_fetch__tool(int argc, const char **argv, const char *prefix)
if (!strcmp("parse-reflist", argv[1])) {
if (argc != 3)
return error("parse-reflist takes 1 arg");
- return parse_reflist(argv[2]);
+ const char *reflist = argv[2];
+ if (!strcmp(reflist, "-"))
+ reflist = get_stdin();
+ return parse_reflist(reflist);
}
if (!strcmp("expand-refs-wildcard", argv[1])) {
if (argc < 4)
return error("expand-refs-wildcard takes at least 2 args");
- return expand_refs_wildcard(argv[2], argc - 3, argv + 3);
+ const char *reflist = argv[2];
+ if (!strcmp(reflist, "-"))
+ reflist = get_stdin();
+ return expand_refs_wildcard(reflist, argc - 3, argv + 3);
}
return error("Unknown subcommand: %s", argv[1]);
--
1.4.4.4
next prev parent reply other threads:[~2007-02-13 1:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 1:21 [PU PATCH] Fix git fetch for very large ref counts Julian Phillips
2007-02-13 1:21 ` Julian Phillips [this message]
2007-02-13 1:21 ` [PATCH] Use stdin reflist passing in parse-remote Julian Phillips
2007-02-13 1:21 ` [PATCH] Use stdin reflist passing in git-fetch.sh Julian Phillips
2007-02-13 2:31 ` Linus Torvalds
2007-02-13 3:18 ` [PU PATCH] Fix git fetch for very large ref counts Junio C Hamano
2007-02-13 10:39 ` Julian Phillips
2007-02-13 17:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11713297013179-git-send-email-julian@quantumfyre.co.uk \
--to=jp3@quantumfyre.co.uk \
--cc=git@vger.kernel.org \
--cc=julian@quantumfyre.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).