From: Matthias Kestenholz <matthias@spinlock.ch>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Documentation: git-daemon inetd configuration fix
Date: Fri, 16 Mar 2007 10:02:09 +0100 [thread overview]
Message-ID: <1174035730.4067.54.camel@localhost.localdomain> (raw)
In-Reply-To: <7vabydwpd5.fsf@assigned-by-dhcp.cox.net>
On Fri, 2007-03-16 at 01:43 -0700, Junio C Hamano wrote:
> Matthias Kestenholz <matthias@spinlock.ch> writes:
>
> > On my debian server, this change was needed to get git-daemon running.
> > I am no inetd expert, so I don't know where the error was.
> >
> > Perhaps this patch might help someone else.
> >
> >
> > diff --git a/Documentation/git-daemon.txt b/Documentation/git-daemon.txt
> > index 9ddab71..499c1f3 100644
> > --- a/Documentation/git-daemon.txt
> > +++ b/Documentation/git-daemon.txt
> > @@ -177,7 +177,7 @@ git-daemon as inetd server::
> > +
> > ------------------------------------------------
> > git stream tcp nowait nobody /usr/bin/git-daemon
> > - git-daemon --inetd --verbose --export-all
> > + /usr/bin/git-daemon --inetd --verbose --export-all
> > /pub/foo /pub/bar
> > ------------------------------------------------
>
> That sounds _very_ wrong. What you changed is argv[0] (i.e. the
> beginning of "service program arguments" field) and it should
> not matter what you have there for inetd to launch git-daemon.
> Presumably your inetd runs with /usr/bin in your path so even
> the "service program" field (the one after 'nobody') should not
> need the full path (but it is a good idea to be explicit in that
> field as a principle), but needing the full path in argv[0]?
>
> On _my_ debian box, I do not need a full path there, so it is
> not even Debian in general but problem is on your particular
> box. Can you dig a bit more to see what you are doing any
> differently?
>
> For example, do you really mean the "service program arguments"
> field that matters?
>
Uhm... I don't get it. I changed the second /usr/bin/git-daemon back to
git-dameon (and even to "foo") and it continues working after restarting
inetd.
I cannot reproduce the problem I had earlier, but everything works fine
with the line from the docs now.
Btw, git is installed in /usr/bin , so that cannot be the reason for the
failure I saw.
Oh well, sorry for the noise and thanks for the fast response.
Matthias
prev parent reply other threads:[~2007-03-16 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 7:54 [PATCH/RFC] Documentation: git-daemon inetd configuration fix Matthias Kestenholz
2007-03-16 8:43 ` Junio C Hamano
2007-03-16 9:02 ` Matthias Kestenholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174035730.4067.54.camel@localhost.localdomain \
--to=matthias@spinlock.ch \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).