git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bowes <jbowes@dangerouslyinc.com>
To: git@vger.kernel.org
Cc: junkio@cox.net, tytso@mit.edu
Subject: [PATCH] mergetool: Use merge.tool config option.
Date: Sun, 18 Mar 2007 12:13:11 -0400	[thread overview]
Message-ID: <11742343911678-git-send-email-jbowes@dangerouslyinc.com> (raw)

If no merge program was supplied on the commandline, and the config option
merge.tool was set to a valid value, then mergetool would unset $merge_tool
and instead try to find an installed merge program. This patch removes the code
that unset $merge_tool, so the merge.tool config option will always be used, if
set.

Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---
 git-mergetool.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/git-mergetool.sh b/git-mergetool.sh
index 52386a5..19788a1 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -288,10 +288,6 @@ done
 
 if test -z "$merge_tool"; then
     merge_tool=`git-config merge.tool`
-    if test $merge_tool = kdiff3 -o $merge_tool = tkdiff -o \
-	$merge_tool = xxdiff -o $merge_tool = meld ; then
-	unset merge_tool
-    fi
 fi
 
 if test -z "$merge_tool" ; then
-- 
1.5.0.3

             reply	other threads:[~2007-03-18 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-18 16:13 James Bowes [this message]
2007-03-19  0:18 ` [PATCH] mergetool: Use merge.tool config option Junio C Hamano
2007-03-19  1:11   ` James Bowes
2007-03-19  2:32     ` Theodore Tso
2007-03-19  4:09       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11742343911678-git-send-email-jbowes@dangerouslyinc.com \
    --to=jbowes@dangerouslyinc.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).