* [PATCH] git-quiltimport /bin/sh-ism fix
@ 2007-03-29 21:38 Francis Daly
2007-03-29 23:06 ` Junio C Hamano
2007-03-30 2:05 ` Wu, Bryan
0 siblings, 2 replies; 3+ messages in thread
From: Francis Daly @ 2007-03-29 21:38 UTC (permalink / raw)
To: git
Bryan Wu reported
/usr/local/bin/git-quiltimport: 114: Syntax error: Missing '))'
Most bourne-ish shells I have here accept
x=$((echo x)|cat)
but all bourne-ish shells I have here accept
x=$( (echo x)|cat)
because $(( might mean arithmetic expansion.
Signed-off-by: Francis Daly <francis@daoine.org>
---
git-quiltimport.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-quiltimport.sh b/git-quiltimport.sh
index 08ac9bb..edccd82 100755
--- a/git-quiltimport.sh
+++ b/git-quiltimport.sh
@@ -115,7 +115,7 @@ for patch_name in $(cat "$QUILT_PATCHES/series" | grep -v '^#'); do
if [ -z "$dry_run" ] ; then
git-apply --index -C1 "$tmp_patch" &&
tree=$(git-write-tree) &&
- commit=$((echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
+ commit=$( (echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
git-update-ref -m "quiltimport: $patch_name" HEAD $commit || exit 4
fi
done
--
1.5.1.rc3-dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-quiltimport /bin/sh-ism fix
2007-03-29 21:38 [PATCH] git-quiltimport /bin/sh-ism fix Francis Daly
@ 2007-03-29 23:06 ` Junio C Hamano
2007-03-30 2:05 ` Wu, Bryan
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2007-03-29 23:06 UTC (permalink / raw)
To: Francis Daly; +Cc: git
Francis Daly <francis@daoine.org> writes:
> Bryan Wu reported
> /usr/local/bin/git-quiltimport: 114: Syntax error: Missing '))'
>
> Most bourne-ish shells I have here accept
> x=$((echo x)|cat)
> but all bourne-ish shells I have here accept
> x=$( (echo x)|cat)
> because $(( might mean arithmetic expansion.
Well spotted, thanks.
Sheesh, this is even warned in POSIX sh manpage.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-quiltimport /bin/sh-ism fix
2007-03-29 21:38 [PATCH] git-quiltimport /bin/sh-ism fix Francis Daly
2007-03-29 23:06 ` Junio C Hamano
@ 2007-03-30 2:05 ` Wu, Bryan
1 sibling, 0 replies; 3+ messages in thread
From: Wu, Bryan @ 2007-03-30 2:05 UTC (permalink / raw)
To: Francis Daly; +Cc: git
On Thu, 2007-03-29 at 22:38 +0100, Francis Daly wrote:
> Bryan Wu reported
> /usr/local/bin/git-quiltimport: 114: Syntax error: Missing '))'
>
> Most bourne-ish shells I have here accept
> x=$((echo x)|cat)
> but all bourne-ish shells I have here accept
> x=$( (echo x)|cat)
> because $(( might mean arithmetic expansion.
>
> Signed-off-by: Francis Daly <francis@daoine.org>
> ---
> git-quiltimport.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-quiltimport.sh b/git-quiltimport.sh
> index 08ac9bb..edccd82 100755
> --- a/git-quiltimport.sh
> +++ b/git-quiltimport.sh
> @@ -115,7 +115,7 @@ for patch_name in $(cat "$QUILT_PATCHES/series" | grep -v '^#'); do
> if [ -z "$dry_run" ] ; then
> git-apply --index -C1 "$tmp_patch" &&
> tree=$(git-write-tree) &&
> - commit=$((echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
> + commit=$( (echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
> git-update-ref -m "quiltimport: $patch_name" HEAD $commit || exit 4
> fi
> done
Cool. Thanks a lot.
-Bryan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-30 2:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-29 21:38 [PATCH] git-quiltimport /bin/sh-ism fix Francis Daly
2007-03-29 23:06 ` Junio C Hamano
2007-03-30 2:05 ` Wu, Bryan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).