Git development
 help / color / mirror / Atom feed
From: Scott Lamb <slamb@slamb.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Scott Lamb <slamb@slamb.org>
Subject: [PATCH] catch asciidoc failures
Date: Thu, 31 May 2007 23:23:57 -0700	[thread overview]
Message-ID: <11806790373908-git-send-email-slamb@slamb.org> (raw)

If pipefail is available (GNU bash >= 3.00), fail when asciidoc returns
error rather than possibly later during XSLT.

Signed-off-by: Scott Lamb <slamb@slamb.org>
---
This is my first git patch, so please let me know if I got the procedure
wrong.

 Documentation/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 3f92783..48c245c 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -111,6 +111,7 @@ clean:
 
 %.html : %.txt
 	rm -f $@+ $@
+	set -o pipefail 2>/dev/null; \
 	$(ASCIIDOC) -b xhtml11 -d manpage -f asciidoc.conf \
 		$(ASCIIDOC_EXTRA) -o - $< | \
 		sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' >$@+
@@ -121,6 +122,7 @@ clean:
 
 %.xml : %.txt
 	rm -f $@+ $@
+	set -o pipefail 2>/dev/null; \
 	$(ASCIIDOC) -b docbook -d manpage -f asciidoc.conf \
 		$(ASCIIDOC_EXTRA) -o - $< | \
 		sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' >$@+
-- 
1.5.2

             reply	other threads:[~2007-06-01  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-01  6:23 Scott Lamb [this message]
2007-06-01  8:36 ` [PATCH] catch asciidoc failures Martin Waitz
2007-06-01  8:55   ` Jonas Fonseca
2007-06-01  9:10   ` Jeff King
2007-06-01  9:39     ` Martin Waitz
2007-06-01  9:43       ` Jeff King
2007-06-01  9:46     ` Scott Lamb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11806790373908-git-send-email-slamb@slamb.org \
    --to=slamb@slamb.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox