* [PATCH] $EMAIL is a last resort fallback, as it's system-wide.
@ 2007-06-05 16:40 Pierre Habouzit
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Habouzit @ 2007-06-05 16:40 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Pierre Habouzit
Rationale: $EMAIL is a system-wide setup that is used for many many many
applications. If the git user chose a specific user.email setup, then _this_
should be honoured rather than $EMAIL.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
ident.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ident.c b/ident.c
index 69a04b8..3d49608 100644
--- a/ident.c
+++ b/ident.c
@@ -196,9 +196,9 @@ const char *fmt_ident(const char *name, const char *email,
if (!name)
name = git_default_name;
if (!email)
- email = getenv("EMAIL");
- if (!email)
email = git_default_email;
+ if (!email)
+ email = getenv("EMAIL");
if (!*name) {
struct passwd *pw;
--
1.5.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] $EMAIL is a last resort fallback, as it's system-wide.
@ 2007-06-05 22:25 Pierre Habouzit
2007-06-05 22:27 ` Pierre Habouzit
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Habouzit @ 2007-06-05 22:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Pierre Habouzit
From: Pierre Habouzit <pierre.habouzit@m4x.org>
Rationale: $EMAIL is a system-wide setup that is used for many many many
applications. If the git user chose a specific user.email setup, then _this_
should be honoured rather than $EMAIL.
Signed-off-by: Pierre Habouzit <pierre.habouzit@m4x.org>
---
ident.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ident.c b/ident.c
index 69a04b8..3d49608 100644
--- a/ident.c
+++ b/ident.c
@@ -196,9 +196,9 @@ const char *fmt_ident(const char *name, const char *email,
if (!name)
name = git_default_name;
if (!email)
- email = getenv("EMAIL");
- if (!email)
email = git_default_email;
+ if (!email)
+ email = getenv("EMAIL");
if (!*name) {
struct passwd *pw;
--
1.5.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] $EMAIL is a last resort fallback, as it's system-wide.
2007-06-05 22:25 Pierre Habouzit
@ 2007-06-05 22:27 ` Pierre Habouzit
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Habouzit @ 2007-06-05 22:27 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
Eeeew sorry for the repost, I sent the bad patch with git send-email.
my mistake.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-05 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-05 16:40 [PATCH] $EMAIL is a last resort fallback, as it's system-wide Pierre Habouzit
-- strict thread matches above, loose matches on Subject: below --
2007-06-05 22:25 Pierre Habouzit
2007-06-05 22:27 ` Pierre Habouzit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).