From: Frank Lichtenheld <frank@lichtenheld.de>
To: git@vger.kernel.org
Cc: Frank Lichtenheld <frank@lichtenheld.de>, Dirk Koopman <djk@tobit.co.uk>
Subject: [PATCH] cvsserver: always initialize state in argsplit()
Date: Sun, 17 Jun 2007 10:31:02 +0200 [thread overview]
Message-ID: <11820690621003-git-send-email-frank@lichtenheld.de> (raw)
In-Reply-To: <11820198064114-git-send-email-djk@tobit.co.uk>
Other code assumes that this is initialized, so do it
even if there were no arguments given.
Signed-off-by: Dirk Koopman <djk@tobit.co.uk>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
---
git-cvsserver.perl | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
Hrm, sorry to Dirk for the double mail. This time actually
send to the list and not to git@localhost ...
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 5cbf27e..10aba50 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -1813,14 +1813,14 @@ sub req_annotate
# the second is $state->{files} which is everything after it.
sub argsplit
{
- return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" );
-
- my $type = shift;
-
$state->{args} = [];
$state->{files} = [];
$state->{opt} = {};
+ return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" );
+
+ my $type = shift;
+
if ( defined($type) )
{
my $opt = {};
--
1.5.2.1
prev parent reply other threads:[~2007-06-17 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-16 18:50 [PATCH] cvsserver: fix legacy cvs client and branch rev issues Dirk Koopman
2007-06-17 8:19 ` Frank Lichtenheld
2007-06-17 9:10 ` Dirk Koopman
2007-06-17 10:37 ` Frank Lichtenheld
2007-06-17 16:53 ` Dirk Koopman
2007-06-17 17:20 ` Frank Lichtenheld
2007-06-17 21:27 ` Martin Langhoff
2007-06-17 8:31 ` Frank Lichtenheld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11820690621003-git-send-email-frank@lichtenheld.de \
--to=frank@lichtenheld.de \
--cc=djk@tobit.co.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).