git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Roman Kagan <rkagan@sw.ru>
Cc: keithp@keithp.com, Al Viro <viro@zeniv.linux.org.uk>,
	git@vger.kernel.org
Subject: Re: parsecvs fails even on simple input
Date: Sun, 24 Jun 2007 22:31:07 +0100	[thread overview]
Message-ID: <1182720667.13289.41.camel@neko.keithp.com> (raw)
In-Reply-To: <20070622113625.GD12473@rkagan.sw.ru>

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Fri, 2007-06-22 at 15:36 +0400, Roman Kagan wrote:

> The problem is the following: after that commit parsecvs tries to add
> objects to the git tree on its own via calls to libgit; however, in
> between it runs git-pack-objects.  Thus objects move to pack files
> without libgit being aware of it; this results in 'ivalid object'
> errors.

Sticking a call to reprepare_packed_git() after the pack creation fixes
this nicely.

>  Wouldn't it be better to teach parsecvs
> to speak git-fast-import language instead?

Avoiding fork/exec is rather important for parsecvs perforamance.

-- 
keith.packard@intel.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-06-25  4:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 11:36 parsecvs fails even on simple input Roman Kagan
2007-06-24 21:31 ` Keith Packard [this message]
2007-06-25  4:59   ` Shawn O. Pearce
2007-06-27 15:33   ` Roman Kagan
2007-06-27 17:20     ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182720667.13289.41.camel@neko.keithp.com \
    --to=keithp@keithp.com \
    --cc=git@vger.kernel.org \
    --cc=rkagan@sw.ru \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).