git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gitk - Ignore ctrl-z as EOF on windows
@ 2007-07-17 22:42 Mark Levedahl
  0 siblings, 0 replies; only message in thread
From: Mark Levedahl @ 2007-07-17 22:42 UTC (permalink / raw)
  To: paulus, Git Mailing List; +Cc: Mark Levedahl

Cygwin's Tcl is configured to honor any occurence of ctrl-z as an
end-of-file marker, while some commits in the git repository and possibly
elsewhere include that character in the commit comment. This causes gitk
ignore commit history following such a comment and incorrect graphs. This
change affects only Windows as Tcl on other platforms already has
eofchar == {}. This fixes problems noted by me and by Ray Lehtiniemi, and
the fix was suggested by Shawn Pierce.

Signed-off-by: Mark Levedahl <mdl123@verizon.net>
---
 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitk b/gitk
index 39e452a..238607e 100755
--- a/gitk
+++ b/gitk
@@ -101,7 +101,7 @@ proc start_rev_list {view} {
     set commfd($view) $fd
     set leftover($view) {}
     set lookingforhead $showlocalchanges
-    fconfigure $fd -blocking 0 -translation lf
+    fconfigure $fd -blocking 0 -translation lf -eofchar {}
     if {$tclencoding != {}} {
 	fconfigure $fd -encoding $tclencoding
     }
-- 
1.5.3.rc2.5.g66bbd

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-17 22:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 22:42 [PATCH] gitk - Ignore ctrl-z as EOF on windows Mark Levedahl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).