git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: Some ideas for StGIT
Date: Mon, 06 Aug 2007 08:42:05 -0400	[thread overview]
Message-ID: <1186404125.10627.30.camel@dv> (raw)
In-Reply-To: <20070806095623.GA23349@diana.vm.bytemark.co.uk>

On Mon, 2007-08-06 at 11:56 +0200, Karl Hasselström wrote:

> I never really understood why commit message editing had to be part of
> the "refresh" command. If it were a separate command and not tied to
> refresh, we could allow editing the message (and author, committer,
> date, ...) of any commit in the stack -- since the tree objects would
> be unchanged, we could just reuse the same tree objects when rewriting
> the commit objects on top of it.
> 
> That's obviously not going to work if we allow editing of the patch.
> But patch editing isn't a good fit as a refresh switch either, since
> it's not at all related to replacing the tree of the current patch
> with the working tree.

Purely from the code standpoint, yes, it should be a separate command.
But it may be practical to have both in one command, since I commonly
need to change the description after changing the code.

We need to think what would be convenient for the normal workflow.

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2007-08-06 12:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 17:50 Some ideas for StGIT Pavel Roskin
2007-08-03 18:14 ` Andy Parkins
2007-08-04  5:41   ` Pavel Roskin
2007-08-04  5:51     ` Shawn O. Pearce
2007-08-05  0:08       ` Pavel Roskin
2007-08-05  0:17       ` Jakub Narebski
2007-08-05  2:31         ` Shawn O. Pearce
2007-08-05  3:32           ` Junio C Hamano
2007-08-05 13:39           ` Josef Sipek
2007-08-05 13:56             ` Johannes Schindelin
2007-08-05 14:06               ` Josef Sipek
2007-08-05 14:15                 ` Johannes Schindelin
2007-08-05 14:57                   ` Josef Sipek
2007-08-04  8:08     ` Yann Dirson
2007-08-06 10:01       ` Catalin Marinas
2007-08-04 14:14     ` Chris Shoemaker
2007-08-04 15:22       ` Johannes Schindelin
2007-08-03 23:23 ` Yann Dirson
2007-08-06  9:49   ` Catalin Marinas
2007-08-06 13:26     ` Pavel Roskin
2007-08-06 15:19       ` Josef Sipek
2007-08-04  6:38 ` Theodore Tso
2007-08-04  8:16   ` Yann Dirson
2007-08-04 21:35   ` Josef Sipek
2007-08-05  0:12     ` Pavel Roskin
2007-08-06  9:36 ` Catalin Marinas
2007-08-06  9:56   ` Karl Hasselström
2007-08-06 12:42     ` Pavel Roskin [this message]
2007-08-06 13:52       ` Karl Hasselström
2007-08-23 14:09         ` Catalin Marinas
2007-08-23 14:34           ` Karl Hasselström
2007-08-06 17:17   ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186404125.10627.30.camel@dv \
    --to=proski@gnu.org \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).