git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] send-email: don't add sender to Cc: if --suppress-from is given.
@ 2007-08-07 13:12 Uwe Kleine-König
  0 siblings, 0 replies; only message in thread
From: Uwe Kleine-König @ 2007-08-07 13:12 UTC (permalink / raw)
  To: Git Mailing List

Up to now the sender is added to the Cc: list for Signed-off-by and Cc
lines even if --suppress-from is requested.

Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
---
Hello,

Maybe the address should be added for a Cc: line, but not for
Signed-off-by?

Best regards
Uwe

 git-send-email.perl |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 39e433b..9d7f6a8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -646,9 +646,11 @@ foreach my $t (@files) {
 			if (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc) {
 				my $c = $2;
 				chomp $c;
-				push @cc, $c;
-				printf("(sob) Adding cc: %s from line '%s'\n",
-					$c, $_) unless $quiet;
+				if (not $suppress_from or unquote_rfc2047($c) eq $from) {
+					push @cc, $c;
+					printf("(sob) Adding cc: %s from line '%s'\n",
+						$c, $_) unless $quiet;
+				}
 			}
 		}
 	}
-- 
1.5.3.rc3.13.g7ab3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-07 13:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-07 13:12 [PATCH] send-email: don't add sender to Cc: if --suppress-from is given Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).