git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Kågedal" <davidk@lysator.liu.se>
To: catalin.marinas@gmail.com, git@vger.kernel.org
Cc: "David Kågedal" <davidk@lysator.liu.se>
Subject: [StGit PATCH 2/6] Don't try to merge files that merge-recursive already merged
Date: Mon, 20 Aug 2007 10:11:59 +0200	[thread overview]
Message-ID: <11875975232734-git-send-email-davidk@lysator.liu.se> (raw)
In-Reply-To: <1187597523433-git-send-email-davidk@lysator.liu.se>

From: David KÃ¥gedal <davidk@lysator.liu.se>

This avoid duplicating work, but also changes the resulting index state
so that the conflicts are left in the index in the three stages.

Signed-off-by: David KÃ¥gedal <davidk@lysator.liu.se>
---
 stgit/git.py |   20 +-------------------
 1 files changed, 1 insertions(+), 19 deletions(-)

diff --git a/stgit/git.py b/stgit/git.py
index 9d8da5d..5e1548c 100644
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -707,25 +707,7 @@ def merge_recursive(base, head1, head2):
         # error and we have to abort the merge
         raise GitException, err_output
 
-    # merge the unmerged files
-    errors = False
-    for path in files:
-        # remove additional files that might be generated for some
-        # newer versions of GIT
-        for suffix in [base, head1, head2]:
-            if not suffix:
-                continue
-            fname = path + '~' + suffix
-            if os.path.exists(fname):
-                os.remove(fname)
-
-        stages = files[path]
-        if gitmergeonefile.merge(stages['1'][1], stages['2'][1],
-                                 stages['3'][1], path, stages['1'][0],
-                                 stages['2'][0], stages['3'][0]) != 0:
-            errors = True
-
-    if errors:
+    if files:
         raise GitException, 'GIT index merging failed (possible conflicts)'
 
 def merge(base, head1, head2):
-- 
1.5.3.rc3.119.g1812

  reply	other threads:[~2007-08-20  8:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20  8:11 [StGit PATCH 0/6] Use git conflict handling on push David Kågedal
2007-08-20  8:11 ` [StGit PATCH 1/6] Split git.merge into two functions David Kågedal
2007-08-20  8:11   ` David Kågedal [this message]
2007-08-20  8:12     ` [StGit PATCH 3/6] Don't touch state after conflict in push David Kågedal
2007-08-20  8:12       ` [StGit PATCH 4/6] Added a test case to check what happens when push finds a conflict David Kågedal
2007-08-20  8:12         ` [StGit PATCH 5/6] Simplify merge_recursive David Kågedal
2007-08-20  8:12           ` [StGit PATCH 6/6] Use the output from merge-recursive to list conflicts David Kågedal
2007-08-22  9:21     ` [StGit PATCH 2/6] Don't try to merge files that merge-recursive already merged Karl Hasselström
2007-08-22  9:37       ` David Kågedal
2007-08-22  9:44         ` Karl Hasselström
2007-08-22  9:59           ` Karl Hasselström
2007-08-22 10:29             ` [StGIT PATCH] Leave working dir and index alone after failed (conflicting) push Karl Hasselström
2007-08-20  8:55   ` [StGit PATCH 1/6] Split git.merge into two functions David Kågedal
2007-08-20 23:52     ` Junio C Hamano
2007-08-21 19:35       ` Uwe Kleine-König
2007-08-22 10:04         ` Junio C Hamano
2007-08-22  9:17 ` [StGit PATCH 0/6] Use git conflict handling on push Karl Hasselström
2007-08-23 14:54 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11875975232734-git-send-email-davidk@lysator.liu.se \
    --to=davidk@lysator.liu.se \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).