git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Kågedal" <davidk@lysator.liu.se>
To: catalin.marinas@gmail.com, git@vger.kernel.org
Cc: "David Kågedal" <davidk@lysator.liu.se>
Subject: [StGit PATCH 5/6] Simplify merge_recursive
Date: Mon, 20 Aug 2007 10:12:02 +0200	[thread overview]
Message-ID: <11875975233747-git-send-email-davidk@lysator.liu.se> (raw)
In-Reply-To: <1187597523884-git-send-email-davidk@lysator.liu.se>

From: David KÃ¥gedal <davidk@lysator.liu.se>

Listing the unmerged files is unnecessary, since the information
isn't really used anyway. Just note if the merge failed or succeeded.

Signed-off-by: David KÃ¥gedal <davidk@lysator.liu.se>
---
 stgit/git.py |   33 ++-------------------------------
 1 files changed, 2 insertions(+), 31 deletions(-)

diff --git a/stgit/git.py b/stgit/git.py
index 5e1548c..63798bd 100644
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -675,39 +675,10 @@ def merge_recursive(base, head1, head2):
     """
     refresh_index()
 
-    err_output = None
-    # this operation tracks renames but it is slower (used in
-    # general when pushing or picking patches)
+    # use _output() to mask the verbose prints of the tool
     try:
-        # use _output() to mask the verbose prints of the tool
         _output(['git-merge-recursive', base, '--', head1, head2])
-    except GitException, ex:
-        err_output = str(ex)
-        pass
-
-    # check the index for unmerged entries
-    files = {}
-
-    for line in _output(['git-ls-files', '--unmerged', '--stage', '-z']).split('\0'):
-        if not line:
-            continue
-
-        mode, hash, stage, path = stages_re.findall(line)[0]
-
-        if not path in files:
-            files[path] = {}
-            files[path]['1'] = ('', '')
-            files[path]['2'] = ('', '')
-            files[path]['3'] = ('', '')
-
-        files[path][stage] = (mode, hash)
-
-    if err_output and not files:
-        # if no unmerged files, there was probably a different type of
-        # error and we have to abort the merge
-        raise GitException, err_output
-
-    if files:
+    except GitException:
         raise GitException, 'GIT index merging failed (possible conflicts)'
 
 def merge(base, head1, head2):
-- 
1.5.3.rc3.119.g1812

  reply	other threads:[~2007-08-20  8:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20  8:11 [StGit PATCH 0/6] Use git conflict handling on push David Kågedal
2007-08-20  8:11 ` [StGit PATCH 1/6] Split git.merge into two functions David Kågedal
2007-08-20  8:11   ` [StGit PATCH 2/6] Don't try to merge files that merge-recursive already merged David Kågedal
2007-08-20  8:12     ` [StGit PATCH 3/6] Don't touch state after conflict in push David Kågedal
2007-08-20  8:12       ` [StGit PATCH 4/6] Added a test case to check what happens when push finds a conflict David Kågedal
2007-08-20  8:12         ` David Kågedal [this message]
2007-08-20  8:12           ` [StGit PATCH 6/6] Use the output from merge-recursive to list conflicts David Kågedal
2007-08-22  9:21     ` [StGit PATCH 2/6] Don't try to merge files that merge-recursive already merged Karl Hasselström
2007-08-22  9:37       ` David Kågedal
2007-08-22  9:44         ` Karl Hasselström
2007-08-22  9:59           ` Karl Hasselström
2007-08-22 10:29             ` [StGIT PATCH] Leave working dir and index alone after failed (conflicting) push Karl Hasselström
2007-08-20  8:55   ` [StGit PATCH 1/6] Split git.merge into two functions David Kågedal
2007-08-20 23:52     ` Junio C Hamano
2007-08-21 19:35       ` Uwe Kleine-König
2007-08-22 10:04         ` Junio C Hamano
2007-08-22  9:17 ` [StGit PATCH 0/6] Use git conflict handling on push Karl Hasselström
2007-08-23 14:54 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11875975233747-git-send-email-davidk@lysator.liu.se \
    --to=davidk@lysator.liu.se \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).