From: "Josh England" <jjengla@sandia.gov>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "David Kastrup" <dak@gnu.org>, git@vger.kernel.org
Subject: Re: tracking perms/ownership
Date: Fri, 24 Aug 2007 12:56:43 -0600 [thread overview]
Message-ID: <1187981803.6357.173.camel@beauty> (raw)
In-Reply-To: <alpine.LFD.0.999.0708241119140.25853@woody.linux-foundation.org>
On Fri, 2007-08-24 at 11:23 -0700, Linus Torvalds wrote:
>
> On Fri, 24 Aug 2007, Josh England wrote:
> >
> > Do you think its OK to cache this stuff in the index, though?
> > write-tree could then just dump the perms/ownership out as gitattributes
> > somewhere.
>
> I'd really prefer not.
>
> The index state - very much by design - matches the filesystem "stat"
> data, not the internal git data. So "ce_size" matches the checked-out
> size, not the native git data size (ie with CRLF conversion, it matches
> not the checked-in data, but the filesystem version).
That's exactly what I'm after, too: having a snapshot of all lstat data
in the index, because I don't want to have to do an extra stat
somewhere.
> And the same really goes for ce_uid/ce_gid: they have to match what's on
> the filesystem, because they are used not to track user information, but
> to verify that the inode data is valid!
But the stat data (even uid/gid) is in there nonetheless, right? If
everything is in there already I wouldn't need to add a thing. I just
want to access the index cache rather than hitting the filesystem
directly.
> Yeah, we could just ignore them for checking "is the inode the same", but
> that would actually end up *defeating* the point of what you want to do:
> at that point, we'd also obviously ignore it when ownership changes!
If we view the index as being a snapshot of the filesystem, and if
perm/ownership data is stored as .gitattributes in the actual repo,
then the perm/ownership engine just has to reconcile between the index
and the .gitattributes file for both the read and write case.
Differences in the write case would result in the .gitattributes being
updated. Differences in the read case would result in chown/chmod being
run in the working tree. Does this make sense?
-JE
next prev parent reply other threads:[~2007-08-24 18:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 17:14 empty directories Josh England
2007-08-21 17:40 ` Sean
2007-08-22 21:25 ` Josh England
2007-08-22 23:25 ` Linus Torvalds
2007-08-22 23:55 ` David Kastrup
2007-08-23 15:24 ` Josh England
2007-08-23 21:51 ` tracking perms/ownership [was: empty directories] Josh England
2007-08-23 22:08 ` tracking perms/ownership Junio C Hamano
2007-08-23 23:30 ` Linus Torvalds
2007-08-24 6:16 ` David Kastrup
2007-08-24 6:37 ` Linus Torvalds
2007-08-24 7:38 ` Josh England
2007-08-24 7:50 ` David Kastrup
2007-08-24 17:51 ` Linus Torvalds
2007-08-24 18:15 ` Josh England
2007-08-24 18:23 ` Linus Torvalds
2007-08-24 18:56 ` Josh England [this message]
2007-08-24 20:37 ` Junio C Hamano
2007-08-24 21:26 ` Josh England
2007-08-24 19:33 ` Robin Rosenberg
2007-08-24 21:30 ` David Kastrup
2007-08-24 7:22 ` Josh England
2007-08-24 7:39 ` Junio C Hamano
2007-08-24 8:19 ` Josh England
2007-08-24 16:11 ` Josh England
2007-08-24 16:27 ` Josh England
2007-08-24 9:38 ` tracking perms/ownership [was: empty directories] Johannes Schindelin
2007-08-24 9:52 ` Jeff King
2007-08-24 15:50 ` Josh England
2007-08-24 20:58 ` Jeff King
2007-08-25 14:31 ` Johannes Schindelin
2007-08-25 14:46 ` tracking perms/ownership Junio C Hamano
2007-08-25 19:35 ` Junio C Hamano
2007-08-24 10:05 ` tracking perms/ownership [was: empty directories] Jeff King
2007-08-25 14:30 ` Johannes Schindelin
2007-08-24 17:10 ` empty directories Jason Garber
2007-08-22 23:40 ` Jakub Narebski
2007-08-22 0:06 ` Jakub Narebski
2007-08-22 4:31 ` Salikh Zakirov
2007-08-22 18:46 ` Linus Torvalds
2007-08-22 19:12 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187981803.6357.173.camel@beauty \
--to=jjengla@sandia.gov \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).