From: Morten Welinder <mwelinder@gmail.com>
To: GIT Mailing List <git@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: unpack_sha1_file issues
Date: Sun, 24 Apr 2005 22:01:38 -0400 [thread overview]
Message-ID: <118833cc05042419012f425f0d@mail.gmail.com> (raw)
unpack_sha1_file is being called by fsck-cache. Therefore it should
not assume that
a \0 occurs within the first 8192 bytes of the uncompressed data.
However, currently
both the sscanf and strlen calls do just that.
Also, unpack_sha1_file should call inflateEnd in a couple of the error cases.
Finally, if *size==0, shouldn't unpack_sha1_file allocate a single
byte to prevent
malloc from returning NULL?
Morten
reply other threads:[~2005-04-25 1:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc05042419012f425f0d@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).