From: Morten Welinder <mwelinder@gmail.com>
To: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix ptrdiff_t vs. int
Date: Fri, 27 May 2005 10:02:56 -0400 [thread overview]
Message-ID: <118833cc05052707026a3dfedd@mail.gmail.com> (raw)
In-Reply-To: <42971EB4.2050403@oberhumer.com>
On 5/27/05, Markus F.X.J. Oberhumer <markus@oberhumer.com> wrote:
> This trivial patch fixes an obvious ptrdiff_t vs. int mismatch. Which
> makes we wonder why Linus isn't hitting this on his ppc64 - maybe it's
> time to start using -Werror...
The best time to start using -Werror is "never". Different compilers
(and versions)
warn about different things, often affected by, say, optimization
switches. Different
system headers contain things that one compiler or another will issue a warning
over.
Thus -Werror is solely for code that needs to work on one compiler, with one set
of switches, with one libc version, and specific versions of included libraries.
It is tempting to submit a patch to the gcc people making -Werror issue a
warning about the trouble using -Werror.
Morten
next prev parent reply other threads:[~2005-05-27 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 13:20 [PATCH] Fix ptrdiff_t vs. int Markus F.X.J. Oberhumer
2005-05-27 13:51 ` Danjel McGougan
2005-05-27 14:02 ` Morten Welinder [this message]
2005-05-27 16:25 ` H. Peter Anvin
2005-05-27 17:18 ` Linus Torvalds
2005-05-27 17:25 ` Linus Torvalds
2005-05-27 17:42 ` Markus F.X.J. Oberhumer
2005-05-27 17:58 ` H. Peter Anvin
2005-05-27 18:13 ` Linus Torvalds
2005-05-27 18:20 ` Junio C Hamano
2005-05-28 4:05 ` [PATCH] Adjust diff-helper to diff-tree -v -z changes Junio C Hamano
2005-05-29 18:31 ` Linus Torvalds
2005-05-29 20:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc05052707026a3dfedd@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=git@vger.kernel.org \
--cc=markus@oberhumer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).