From: "Morten Welinder" <mwelinder@gmail.com>
To: "Peter Hagervall" <hager@cs.umu.se>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] C version of git-count-objects
Date: Thu, 27 Apr 2006 09:16:32 -0400 [thread overview]
Message-ID: <118833cc0604270616u2961ab10waef5807c429be784@mail.gmail.com> (raw)
In-Reply-To: <20060427101254.GA22769@peppar.cs.umu.se>
> + if (access(subdir, R_OK | X_OK))
> + continue;
> + chdir(subdir);
You've got yourself a needless race condition right there. Just
do the chdir and check the return value. (And besides, access
checks with the wrong set of permissions, should this ever end
up in set[ug]id context.)
Morten
next prev parent reply other threads:[~2006-04-27 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 10:12 [PATCH] C version of git-count-objects Peter Hagervall
2006-04-27 13:16 ` Morten Welinder [this message]
2006-04-27 13:23 ` Nicolas Pitre
2006-04-27 14:07 ` [PATCH] C version of git-count-objects, second try Peter Hagervall
2006-04-27 18:56 ` [PATCH] C version of git-count-objects Junio C Hamano
2006-04-27 19:39 ` Nicolas Pitre
2006-04-27 19:46 ` Peter Hagervall
2006-04-27 20:07 ` Linus Torvalds
2006-04-27 20:51 ` Peter Hagervall
2006-04-27 22:07 ` Junio C Hamano
2006-04-28 0:10 ` Peter Hagervall
2006-04-28 0:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc0604270616u2961ab10waef5807c429be784@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=git@vger.kernel.org \
--cc=hager@cs.umu.se \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).