git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Morten Welinder" <mwelinder@gmail.com>
To: "Matthias Lederhofer" <matled@gmx.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] daemon: if one of the standard fds is missing open it to /dev/null
Date: Thu, 13 Jul 2006 11:37:50 -0400	[thread overview]
Message-ID: <118833cc0607130837u30c58d53lc785f56d45ef970c@mail.gmail.com> (raw)
In-Reply-To: <E1G0znB-0002IO-61@moooo.ath.cx>

> +               if (devnull == -1 &&
> +                       (devnull = open("/dev/null", O_RDWR, 0)) == -1)
> +                       die("open /dev/null failed: %s", strerror(errno));
> +               if (dup2(devnull, i) != i)
> +                       die("dup2 failed: %s", strerror(errno));

"die" probably won't work well at this point.

Should git (and most other programs) do something like this in general?
fprintf will happily write to fd=2 regardless of whether that is some critical
file you opened.

Morten

  parent reply	other threads:[~2006-07-13 15:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-11 22:24 git-daemon problem Matthias Lederhofer
2006-07-11 23:04 ` Junio C Hamano
2006-07-11 23:32 ` Junio C Hamano
2006-07-12  4:42 ` Junio C Hamano
2006-07-12 19:28   ` Matthias Lederhofer
2006-07-13  5:44     ` Junio C Hamano
2006-07-13  7:42       ` Matthias Lederhofer
2006-07-13 11:42       ` Andre Noll
2006-07-13 11:51 ` Matthias Lederhofer
2006-07-13 10:02   ` [PATCH 1/5] daemon: use a custom die routine with syslog Matthias Lederhofer
2006-07-13 10:10   ` [PATCH 2/5] daemon: if one of the standard fds is missing open it to /dev/null Matthias Lederhofer
2006-07-13 13:27     ` Edgar Toernig
2006-07-13 14:04       ` Matthias Lederhofer
2006-07-13 14:36         ` Uwe Zeisberger
2006-07-13 15:37     ` Morten Welinder [this message]
2006-07-13 16:03       ` Matthias Lederhofer
2006-07-13 16:32     ` [PATCH 2.1/5] " Matthias Lederhofer
2006-07-13 10:18   ` [PATCH 4/5] daemon: new option --pid-file=<path> to store the pid Matthias Lederhofer
2006-07-13 10:32   ` [PATCH 5/5] daemon: new option --detach to run git-daemon in background Matthias Lederhofer
2006-07-13 13:37     ` Edgar Toernig
2006-07-13 16:47       ` [PATCH 5.1/5] " Matthias Lederhofer
2006-07-13 11:07   ` [PATCH 3/5] upload-pack: ignore write errors to stderr Matthias Lederhofer
2006-07-14 15:53   ` [PATCH] daemon: documentation for --reuseaddr, --detach and --pid-file Matthias Lederhofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=118833cc0607130837u30c58d53lc785f56d45ef970c@mail.gmail.com \
    --to=mwelinder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=matled@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).