From: "Morten Welinder" <mwelinder@gmail.com>
To: "James Bowes" <jbowes@dangerouslyinc.com>
Cc: junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH] use xrealloc in help.c
Date: Tue, 27 Mar 2007 18:40:45 -0400 [thread overview]
Message-ID: <118833cc0703271540l6615b413gd1df3dc5525a2d00@mail.gmail.com> (raw)
In-Reply-To: <1175034608589-git-send-email-jbowes@dangerouslyinc.com>
> - cmdname = realloc(cmdname, cmdname_alloc * sizeof(*cmdname));
> + cmdname = xrealloc(cmdname, cmdname_alloc * sizeof(*cmdname));
> if (!cmdname)
> oom();
If you are using xrealloc, shouldn't kill the oom check here too?
M.
next prev parent reply other threads:[~2007-03-27 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 22:30 [PATCH] use xrealloc in help.c James Bowes
2007-03-27 22:40 ` Morten Welinder [this message]
2007-03-28 0:53 ` James Bowes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc0703271540l6615b413gd1df3dc5525a2d00@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jbowes@dangerouslyinc.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).