git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Morten Welinder" <mwelinder@gmail.com>
To: "Lars Knoll" <lars@trolltech.com>
Cc: git@vger.kernel.org, "Pierre Habouzit" <madcoder@debian.org>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] Speedup scanning for excluded files.
Date: Mon, 29 Oct 2007 18:59:00 -0400	[thread overview]
Message-ID: <118833cc0710291559kbd874a8o8111b9495090ef27@mail.gmail.com> (raw)
In-Reply-To: <200710290959.32538.lars@trolltech.com>

> +                               } else if (x->flags & EXC_FLAG_ENDSWITH) {
> +                                       if (!strcmp(exclude + 1, pathname + pathlen -x->patternlen + 1))

Is there some guarantee that the result of that subtraction is still within
the string?

Morten

  parent reply	other threads:[~2007-10-29 22:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29  7:45 [PATCH] Speedup scanning for excluded files Lars Knoll
2007-10-29  8:02 ` Pierre Habouzit
2007-10-29  8:59   ` Lars Knoll
2007-10-29 22:17     ` Junio C Hamano
2007-10-29 22:59     ` Morten Welinder [this message]
2007-10-30  0:00       ` Junio C Hamano
2007-10-30  7:28         ` Lars Knoll
2007-10-30  7:46           ` [PATCH v3] " Lars Knoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=118833cc0710291559kbd874a8o8111b9495090ef27@mail.gmail.com \
    --to=mwelinder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lars@trolltech.com \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).