From: "Morten Welinder" <mwelinder@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: "GIT Mailing List" <git@vger.kernel.org>
Subject: Re: cvsimport and branches with "(" in the name
Date: Tue, 29 Apr 2008 20:45:42 -0400 [thread overview]
Message-ID: <118833cc0804291745m2da2a3bdl21a9440e961afb6@mail.gmail.com> (raw)
In-Reply-To: <20080429155238.GA18494@sigill.intra.peff.net>
> - system("git-update-ref $remote/$branch $cid") == 0
> + system('git-update-ref', "$remote/$branch", $cid) == 0
I hope there are no further such system calls left. This could run arbitrary
commands if one was tricked into importing an evil repository.
Morten
next prev parent reply other threads:[~2008-04-30 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 7:22 cvsimport and branches with "(" in the name Nigel Magnay
2008-04-29 15:52 ` Jeff King
2008-04-30 0:45 ` Morten Welinder [this message]
2008-04-30 3:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc0804291745m2da2a3bdl21a9440e961afb6@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).