From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCH 11/14] gitweb: git_is_head_detached() function
Date: Fri, 31 Aug 2007 13:19:11 +0200 [thread overview]
Message-ID: <11885591601143-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <11885591542097-git-send-email-giuseppe.bilotta@gmail.com>
The function checks if the HEAD for the current project is detached by checking if 'git branch' returns "* (no branch)"
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
gitweb/gitweb.perl | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index e743c3d..a745434 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1416,6 +1416,13 @@ sub git_get_head_hash {
return $retval;
}
+# check if current HEAD is detached
+sub git_is_head_detached {
+ my @x = (git_cmd(), 'branch');
+ my @ret = split("\n", qx(@x));
+ return 0 + grep { /^* \(no branch\)$/ } @ret;
+}
+
# get type of given object
sub git_get_type {
my $hash = shift;
@@ -2091,11 +2098,9 @@ sub git_get_heads_list {
my @headslist;
if (grep { $_ eq 'heads' } @class) {
- my @x = (git_cmd(), 'branch');
- my @ret = split("\n", qx(@x));
- if (grep { /^* \(no branch\)$/ } @ret) { ;
+ if (git_is_head_detached()) { ;
my %ref_item;
- @x = (git_cmd(), 'log', '-1', '--pretty=format:%H%n%ct%n%s');
+ my @x = (git_cmd(), 'log', '-1', '--pretty=format:%H%n%ct%n%s');
my ($hash, $epoch, $title) = split("\n", qx(@x), 3);
$ref_item{'class'} = 'head';
--
1.5.2.5
next prev parent reply other threads:[~2007-08-31 11:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 22:24 gitweb and remote branches Giuseppe Bilotta
2007-08-27 23:29 ` Jakub Narebski
[not found] ` <cb7bb73a0708280253y7d31f347yb84a40982d59d9d2@mail.gmail.com>
[not found] ` <cb7bb73a0708280453k4315e80ej170238a52e66dcb6@mail.gmail.com>
2007-08-29 22:01 ` Jakub Narebski
2007-08-30 7:18 ` Giuseppe Bilotta
2007-08-30 8:16 ` Jakub Narebski
2007-08-30 9:09 ` Giuseppe Bilotta
2007-08-30 21:07 ` Junio C Hamano
2007-08-30 23:09 ` Giuseppe Bilotta
2007-08-30 23:53 ` Jakub Narebski
2007-08-30 23:59 ` Giuseppe Bilotta
2007-08-31 2:15 ` Giuseppe Bilotta
2007-08-31 10:54 ` [PATCH 01/14] gitweb: get remotes too when getting heads list Giuseppe Bilotta
2007-08-31 10:55 ` [PATCH 02/14] gitweb: make remote heads in heads list optional Giuseppe Bilotta
2007-08-31 10:55 ` [PATCH 03/14] gitweb: git_get_heads_list now accepts an optional list of refs Giuseppe Bilotta
2007-08-31 10:55 ` [PATCH 04/14] gitweb: separate heads and remotes list in summary view Giuseppe Bilotta
2007-08-31 10:59 ` [PATCH 05/14] gitweb: allow refs passed to git_heads_body to use a name different from the hash name Giuseppe Bilotta
2007-08-31 11:05 ` [PATCH 06/14] gitweb: git_split_heads_body function Giuseppe Bilotta
2007-08-31 11:18 ` [PATCH 07/14] gitweb: use CSS to style split head lists Giuseppe Bilotta
2007-08-31 11:18 ` [PATCH 08/14] gitweb: add 'remotes' action as a synonym for git_heads() Giuseppe Bilotta
2007-08-31 11:18 ` [PATCH 09/14] gitweb: split heads list in head view if appropriate Giuseppe Bilotta
2007-08-31 11:19 ` [PATCH 10/14] gitweb: display HEAD in heads list when detached Giuseppe Bilotta
2007-08-31 11:19 ` Giuseppe Bilotta [this message]
2007-08-31 11:19 ` [PATCH 12/14] gitweb: add HEAD to list of shortlog refs if detached Giuseppe Bilotta
2007-08-31 11:19 ` [PATCH 13/14] gitweb: CSS style and refs mark for detached HEAD Giuseppe Bilotta
2007-08-31 11:19 ` [PATCH 14/14] gitweb: minor whitespace cleanups Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11885591601143-git-send-email-giuseppe.bilotta@gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).