From: "Kristian Høgsberg" <krh@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Move option parsing code to parse-options.[ch].
Date: Mon, 24 Sep 2007 14:41:02 -0400 [thread overview]
Message-ID: <1190659262.10444.1.camel@hinata.boston.redhat.com> (raw)
In-Reply-To: <7vsl57iz1t.fsf@gitster.siamese.dyndns.org>
On Fri, 2007-09-21 at 12:44 -0700, Junio C Hamano wrote:
> Kristian Høgsberg <krh@redhat.com> writes:
>
> > Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> > ---
> > Makefile | 2 +-
> > builtin-commit.c | 117 ++++++++----------------------------------------------
> > parse-options.c | 74 ++++++++++++++++++++++++++++++++++
> > parse-options.h | 29 +++++++++++++
> > 4 files changed, 121 insertions(+), 101 deletions(-)
> > create mode 100644 parse-options.c
> > create mode 100644 parse-options.h
>
> Hmmmmmmm. Is it too much to ask to pretend as if the previous
> "builtin-commit.c" that had these parts that did not belong to
> it in the first place never happened?
No problem, I wasn't sure whether to update the patches or to just send
follow-up patches now that it was in pu. I'll resend 7/7 as 3 new
patches that exports add_files_to_cache(), adds option parsing, and
finally builtin-commit.
Kristian
prev parent reply other threads:[~2007-09-24 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 19:01 [PATCH] Move option parsing code to parse-options.[ch] Kristian Høgsberg
2007-09-21 19:01 ` [PATCH] Share add_files_to_cache() with builtin-add.c Kristian Høgsberg
2007-09-21 19:44 ` [PATCH] Move option parsing code to parse-options.[ch] Junio C Hamano
2007-09-24 18:41 ` Kristian Høgsberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190659262.10444.1.camel@hinata.boston.redhat.com \
--to=krh@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).