From: Denis Cheng <crquan@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, cr_quan@163.com
Subject: [PATCH] gitview: revamped to use string.join, stripped a function def
Date: Fri, 28 Sep 2007 03:55:17 +0800 [thread overview]
Message-ID: <1190922917-5044-1-git-send-email-crquan@gmail.com> (raw)
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
contrib/gitview/gitview | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
index 5931766..2eb72b1 100755
--- a/contrib/gitview/gitview
+++ b/contrib/gitview/gitview
@@ -36,17 +36,6 @@ except ImportError:
re_ident = re.compile('(author|committer) (?P<ident>.*) (?P<epoch>\d+) (?P<tz>[+-]\d{4})')
-def list_to_string(args, skip):
- count = len(args)
- i = skip
- str_arg=" "
- while (i < count ):
- str_arg = str_arg + args[i]
- str_arg = str_arg + " "
- i = i+1
-
- return str_arg
-
def show_date(epoch, tz):
secs = float(epoch)
tzsecs = float(tz[1:3]) * 3600
@@ -1115,7 +1104,7 @@ class GitView(object):
def set_branch(self, args):
"""Fill in different windows with info from the reposiroty"""
- fp = os.popen("git rev-parse --sq --default HEAD " + list_to_string(args, 1))
+ fp = os.popen("git rev-parse --sq --default HEAD " + " ".join(args[1:]))
git_rev_list_cmd = fp.read()
fp.close()
fp = os.popen("git rev-list --header --topo-order --parents " + git_rev_list_cmd)
--
1.5.3.2
next reply other threads:[~2007-09-27 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 19:55 Denis Cheng [this message]
2007-11-21 5:19 ` [PATCH] gitview: revamped to use string.join, stripped a function def rae l
2007-11-21 6:23 ` Vineet Kumar
2007-11-21 6:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190922917-5044-1-git-send-email-crquan@gmail.com \
--to=crquan@gmail.com \
--cc=aneesh.kumar@gmail.com \
--cc=cr_quan@163.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).