Re: Relating to some syntax error in the gitk script

Re: Relating to some syntax error in the gitk script

[Brett Schwarz]

> 
> When I am running the gitk command I get the following error message:-
> 
> ========================================================================
> ===========================
> Error in startup script: syntax error in expression "$i >= [llength
> $argv] && $revtreeargs ne {}"
>     while executing
> "if {$i >= [llength $argv] && $revtreeargs ne {}} {
>     # no -- on command line, but some arguments (other than -d)
>     if {[catch {
>         set f [eval exec..."
>     (file "./gitk" line 7912)
> ========================================================================
> ============================
> 
> Is there a problem with the script or is it a problem with my
> environment...?
> 

What version of Tcl are you running? You should be using >= 8.4





       
____________________________________________________________________________________
Yahoo! oneSearch: Finally, mobile search 
that gives answers, not web links. 
http://mobile.yahoo.com/mobileweb/onesearch?refer=1ONXIC

[PATCH] gitk: add check for required tcl version >= 8.4

[Steffen Prohaska]

gitk requires tcl version >= 8.4 to work flawlessly. So let's
check the tcl version and quit if it's too low.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
 gitk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 300fdce..6ea6489 100755
--- a/gitk
+++ b/gitk
@@ -7,6 +7,11 @@ exec wish "$0" -- "$@"
 # and distributed under the terms of the GNU General Public Licence,
 # either version 2, or (at your option) any later version.
 
+if {[info tclversion] < 8.4} {
+   puts stderr "Sorry, gitk requires tcl version >= 8.4."
+   exit 1 
+}
+
 proc gitdir {} {
     global env
     if {[info exists env(GIT_DIR)]} {
-- 
1.5.3.2.111.g5166

[PATCH] gitk: add check for required tcl version >= 8.4

[Junio C Hamano]

From: Steffen Prohaska <prohaska@zib.de>
Date: Fri, 28 Sep 2007 22:57:22 +0200

gitk requires tcl version >= 8.4 to work flawlessly. So let's
check the tcl version and quit if it's too low.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---

 * I do not have a ready access to older tcl/tk myself, so I
   cannot judge if this is sensible or not.  Just forwarding in
   case you missed it.

 gitk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 300fdce..6ea6489 100755
--- a/gitk
+++ b/gitk
@@ -7,6 +7,11 @@ exec wish "$0" -- "$@"
 # and distributed under the terms of the GNU General Public Licence,
 # either version 2, or (at your option) any later version.
 
+if {[info tclversion] < 8.4} {
+   puts stderr "Sorry, gitk requires tcl version >= 8.4."
+   exit 1 
+}
+
 proc gitdir {} {
     global env
     if {[info exists env(GIT_DIR)]} {
-- 
1.5.3.2.111.g5166

Re: [PATCH] gitk: add check for required tcl version >= 8.4

[Paul Mackerras]

Junio C Hamano writes:

> From: Steffen Prohaska <prohaska@zib.de>
> Date: Fri, 28 Sep 2007 22:57:22 +0200
> 
> gitk requires tcl version >= 8.4 to work flawlessly. So let's
> check the tcl version and quit if it's too low.
> 
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
> ---
> 
>  * I do not have a ready access to older tcl/tk myself, so I
>    cannot judge if this is sensible or not.  Just forwarding in
>    case you missed it.

Thanks for the patch.  I have put in something similar using the
package require command, and using show_error to display the error in
a window.

Paul.