From: jean.guyader@linkea.org
To: git@vger.kernel.org
Cc: Jean Guyader <jean.guyader@gmail.com>
Subject: [PATCH] Fix problem with authentification on http repository.
Date: Sun, 30 Sep 2007 00:26:22 +0200 [thread overview]
Message-ID: <11911047823308-git-send-email-jean.guyader@linkea.org> (raw)
From: Jean Guyader <jean.guyader@gmail.com>
Curl uses the option -u user:passwd and not the user:password
given in the url.
The solution was to extract user:password from the url and set
the option.
Here the regex used :
sed -re 's-.*http://([^:]*):([^@]+)@.*-\1:\2-g'
---
git-clone.sh | 3 ++-
git-fetch.sh | 8 ++++----
git-ls-remote.sh | 3 ++-
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index 5e582fe..57206ac 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -34,7 +34,8 @@ fi
http_fetch () {
# $1 = Remote, $2 = Local
- curl -nsfL $curl_extra_args "$1" >"$2" ||
+ curl_userpw=`echo "$1" | sed -re 's-http://([^:]*):([^@]+)@.*-\1:\2-g'`
+ curl -u "$curl_userpw" -nsfL $curl_extra_args "$1" >"$2" ||
case $? in
126|127) exit ;;
*) return $? ;;
diff --git a/git-fetch.sh b/git-fetch.sh
index e44af2c..0b7d055 100755
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -268,13 +268,13 @@ fetch_per_ref () {
"`git config --bool http.noEPSV`" = true ]; then
noepsv_opt="--disable-epsv"
fi
-
- # Find $remote_name from ls-remote output.
+ pretty_remote=$(echo "$remote" | sed -re 's-http://([^:]+):([^@]+)@-http://\1:******@-g')
+ # Find $remote_name from ls-remote output.
head=$(echo "$ls_remote_result" | \
git fetch--tool -s pick-rref "$remote_name" "-")
expr "z$head" : "z$_x40\$" >/dev/null ||
- die "No such ref $remote_name at $remote"
- echo >&2 "Fetching $remote_name from $remote using $proto"
+ die "No such ref $remote_name at $pretty_remote"
+ echo >&2 "Fetching $remote_name from $pretty_remote using $proto"
case "$quiet" in '') v=-v ;; *) v= ;; esac
git-http-fetch $v -a "$head" "$remote" || exit
;;
diff --git a/git-ls-remote.sh b/git-ls-remote.sh
index d56cf92..d6e9906 100755
--- a/git-ls-remote.sh
+++ b/git-ls-remote.sh
@@ -61,7 +61,8 @@ http://* | https://* | ftp://* )
"`git config --bool http.noEPSV`" = true ]; then
curl_extra_args="${curl_extra_args} --disable-epsv"
fi
- curl -nsf $curl_extra_args --header "Pragma: no-cache" "$peek_repo/info/refs" ||
+ curl_userpw=`echo "$peek_repo" | sed -re 's-.*http://([^:]*):([^@]+)@.*-\1:\2-g'`
+ curl -u "$curl_userpw" -nsf $curl_extra_args --header "Pragma: no-cache" "$peek_repo/info/refs" ||
echo "failed slurping"
;;
--
1.5.2.4
next reply other threads:[~2007-09-29 22:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 22:26 jean.guyader [this message]
2007-09-29 23:10 ` [PATCH] Fix problem with authentification on http repository Johannes Schindelin
2007-09-29 23:38 ` Junio C Hamano
2007-09-29 23:40 ` Johannes Schindelin
2007-09-30 0:02 ` Junio C Hamano
2008-07-09 5:44 ` Junio C Hamano
2008-07-09 5:51 ` Mike Hommey
2008-07-09 6:28 ` Junio C Hamano
2008-07-09 7:53 ` Mike Hommey
2008-07-09 8:04 ` Daniel Stenberg
2008-07-09 8:18 ` Junio C Hamano
2008-07-09 8:56 ` Mike Hommey
2008-07-09 11:43 ` Johannes Schindelin
2008-07-10 7:24 ` Jeff King
2008-07-10 7:32 ` Junio C Hamano
2008-07-10 8:47 ` Jeff King
2008-07-10 10:51 ` Johannes Schindelin
2008-07-10 11:30 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11911047823308-git-send-email-jean.guyader@linkea.org \
--to=jean.guyader@linkea.org \
--cc=git@vger.kernel.org \
--cc=jean.guyader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).