From: Pierre Habouzit <madcoder@debian.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: strbuf `filter' API
Date: Fri, 5 Oct 2007 22:19:29 +0200 [thread overview]
Message-ID: <1191615571-15946-1-git-send-email-madcoder@debian.org> (raw)
In-Reply-To: 20071005155023.GA20305@artemis.corp
Ooookay,
I wasn't more thrilled about the previous patch than linus is. Here is
a possible API to hide the muck in the strbuf.c module, and have a way
nicer to read code in convert.c.
It remais as efficient as the previous code, tries to reuse the buffer
as much as possible to avoid reallocations, and deal with even more
cases (it's possible to have the "source" buffer be inside the
destination strbuf now, which could sometimes help a lot).
I based this on top of master (because it's where my previous patch
was) but it should apply on next properly. It depends upon the previous
patch though.
I'd say that the previous patch should go in master ASAP, and that
those two could be considered for next (having merged master in it first
btw).
Cheers,
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
next reply other threads:[~2007-10-05 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 20:19 Pierre Habouzit [this message]
[not found] ` <1191615571-15946-2-git-send-email-madcoder@debian.org>
2007-10-06 9:06 ` [PATCH 1/2] Have a filter_start/filter_end API Alex Riesen
2007-10-07 14:53 ` Pierre Habouzit
2007-10-07 16:07 ` Alex Riesen
2007-10-07 16:52 ` Pierre Habouzit
2007-10-07 21:50 ` Alex Riesen
2007-10-08 7:29 ` Pierre Habouzit
2007-10-08 18:48 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191615571-15946-1-git-send-email-madcoder@debian.org \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).