From: "Scott R Parish" <srp@srparish.net>
To: "Alex Riesen" <raa.lkml@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] use only the PATH for exec'ing git commands
Date: Mon, 22 Oct 2007 14:59:06 -0500 (CDT) [thread overview]
Message-ID: <1193083146.v2.fusewebmail-240137@f> (raw)
> Alex Reisen, Mon, Oct 22, 2007 12:01:
> > + strbuf_addch(out, ':');
>
> Shouldn't it break MingW32 native port?
>
<snip>
> > + if (old_path)
> > + strbuf_addstr(&new_path, old_path);
> > + else
> > + strbuf_addstr(&new_path,
"/usr/local/bin:/usr/bin:/bin");
>
> the default PATH is platform-dependent. Git is multi-platform.
> You should consider putting the path list somewhere in Makefile,
> config.mak or configure.
>
The original code was already doing both of these things (see git.c's
prepend_to_path())
sRp
next reply other threads:[~2007-10-22 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 19:59 Scott R Parish [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-22 22:12 [PATCH] use only the PATH for exec'ing git commands Scott R Parish
2007-10-22 22:40 ` Alex Riesen
2007-10-22 23:34 ` Johannes Schindelin
2007-10-23 6:14 ` Johannes Sixt
2007-10-22 19:59 Scott R Parish
2007-10-22 20:57 ` Alex Riesen
2007-10-22 17:01 Scott R Parish
2007-10-22 17:44 ` Johannes Schindelin
2007-10-22 19:01 ` Alex Riesen
2007-10-22 19:25 ` Eric Merritt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193083146.v2.fusewebmail-240137@f \
--to=srp@srparish.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).