From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott R Parish Subject: [PATCH 7/7] shell should call setup_path() instead of manually setting up its path Date: Wed, 24 Oct 2007 20:37:17 -0700 Message-ID: <1193283437-1706-7-git-send-email-srp@srparish.net> References: <1193283437-1706-1-git-send-email-srp@srparish.net> <1193283437-1706-2-git-send-email-srp@srparish.net> <1193283437-1706-3-git-send-email-srp@srparish.net> <1193283437-1706-4-git-send-email-srp@srparish.net> <1193283437-1706-5-git-send-email-srp@srparish.net> <1193283437-1706-6-git-send-email-srp@srparish.net> Cc: Scott R Parish To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Oct 25 05:45:10 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iktee-000519-Ls for gcvg-git-2@gmane.org; Thu, 25 Oct 2007 05:45:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757013AbXJYDoz (ORCPT ); Wed, 24 Oct 2007 23:44:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757012AbXJYDoy (ORCPT ); Wed, 24 Oct 2007 23:44:54 -0400 Received: from smtp-gw51.mailanyone.net ([208.70.128.77]:36074 "EHLO smtp-gw51.mailanyone.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756977AbXJYDow (ORCPT ); Wed, 24 Oct 2007 23:44:52 -0400 Received: from mailanyone.net by smtp-gw51.mailanyone.net with esmtp (MailAnyone extSMTP quinn@srparish.net) id 1IkteN-0007Qb-OK; Wed, 24 Oct 2007 22:44:51 -0500 Received: by maple.srparish.net (Postfix, from userid 501) id 726324ECF0F; Wed, 24 Oct 2007 20:37:18 -0700 (PDT) X-Mailer: git-send-email gitgui.0.8.4.11178.g9a1bf-dirty In-Reply-To: <1193283437-1706-6-git-send-email-srp@srparish.net> Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Signed-off-by: Scott R Parish --- shell.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/shell.c b/shell.c index cfe372b..9826109 100644 --- a/shell.c +++ b/shell.c @@ -24,17 +24,11 @@ static int do_cvs_cmd(const char *me, char *arg) const char *cvsserver_argv[3] = { "cvsserver", "server", NULL }; - const char *oldpath = getenv("PATH"); - struct strbuf newpath = STRBUF_INIT; if (!arg || strcmp(arg, "server")) die("git-cvsserver only handles server: %s", arg); - strbuf_addstr(&newpath, git_exec_path()); - strbuf_addch(&newpath, ':'); - strbuf_addstr(&newpath, oldpath); - - setenv("PATH", strbuf_detach(&newpath, NULL), 1); + setup_path(NULL); return execv_git_cmd(cvsserver_argv); } -- gitgui.0.8.4.11176.gd9205-dirty