git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Miklos Vajna <vmiklos@frugalware.org>, git@vger.kernel.org
Subject: [PATCH] Document that using -M without other diff options is not a good idea
Date: Thu,  1 Nov 2007 15:57:39 +0100	[thread overview]
Message-ID: <1193929060-6183-1-git-send-email-vmiklos@frugalware.org> (raw)

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---

I just noticed that I used 'git log -M' in some scripts which is obviously bad.
People should not use that option without other diff options.

 Documentation/diff-options.txt |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index b1f528a..ed827f8 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -92,7 +92,9 @@
 	Break complete rewrite changes into pairs of delete and create.
 
 -M::
-	Detect renames.
+	Detect renames. It's no good using this option if you don't use diff
+	options like `--name-status`, `-p` or `--stat` as it will just slow
+	down the revision walker.
 
 -C::
 	Detect copies as well as renames.  See also `--find-copies-harder`.
-- 
1.5.3.5

             reply	other threads:[~2007-11-01 14:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01 14:57 Miklos Vajna [this message]
2007-11-01 14:57 ` [PATCH] Include diff options in the git-log manpage Miklos Vajna
2007-11-12 15:37   ` Miklos Vajna
2007-12-04 12:28   ` Miklos Vajna
2007-12-04 17:57     ` Junio C Hamano
2007-12-05  6:45     ` Junio C Hamano
2007-11-01 15:09 ` [PATCH] Document that using -M without other diff options is not a good idea Johannes Schindelin
2007-11-01 15:24   ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193929060-6183-1-git-send-email-vmiklos@frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).