From: Blake Ramsdell <blaker@gmail.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: Blake Ramsdell <blaker@gmail.com>
Subject: [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly
Date: Fri, 2 Nov 2007 17:00:10 -0700 [thread overview]
Message-ID: <1194048010-65955-1-git-send-email-blaker@gmail.com> (raw)
In-Reply-To: <985966520711021303g905f638y2056219c22e5edeb@mail.gmail.com>
Signed-off-by: Blake Ramsdell <blaker@gmail.com>
---
Makefile | 8 --------
utf8.c | 2 +-
2 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index 71479a2..96c8a73 100644
--- a/Makefile
+++ b/Makefile
@@ -95,9 +95,6 @@ all::
#
# Define NO_ICONV if your libc does not properly support iconv.
#
-# Define OLD_ICONV if your library has an old iconv(), where the second
-# (input buffer pointer) parameter is declared with type (const char **).
-#
# Define NO_R_TO_GCC_LINKER if your gcc does not like "-R/path/lib"
# that tells runtime paths to dynamic libraries;
# "-Wl,-rpath=/path/lib" is used instead.
@@ -401,7 +398,6 @@ endif
ifeq ($(uname_S),Darwin)
NEEDS_SSL_WITH_CRYPTO = YesPlease
NEEDS_LIBICONV = YesPlease
- OLD_ICONV = UnfortunatelyYes
NO_STRLCPY = YesPlease
NO_MEMMEM = YesPlease
endif
@@ -657,10 +653,6 @@ ifdef NO_ICONV
BASIC_CFLAGS += -DNO_ICONV
endif
-ifdef OLD_ICONV
- BASIC_CFLAGS += -DOLD_ICONV
-endif
-
ifdef PPC_SHA1
SHA1_HEADER = "ppc/sha1.h"
LIB_OBJS += ppc/sha1.o ppc/sha1ppc.o
diff --git a/utf8.c b/utf8.c
index 4efef6f..a7feb4f 100644
--- a/utf8.c
+++ b/utf8.c
@@ -300,7 +300,7 @@ int is_encoding_utf8(const char *name)
* with iconv. If the conversion fails, returns NULL.
*/
#ifndef NO_ICONV
-#ifdef OLD_ICONV
+#if _LIBICONV_VERSION <= 0x0109
typedef const char * iconv_ibp;
#else
typedef char * iconv_ibp;
--
1.5.3.GIT
next prev parent reply other threads:[~2007-11-03 0:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 2:38 [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Blake Ramsdell
2007-11-02 2:38 ` [PATCH] Fixed a gcc 4.0.1 complaint about an uninitialized variable Blake Ramsdell
2007-11-02 5:37 ` Junio C Hamano
2007-11-02 9:03 ` [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Junio C Hamano
2007-11-02 9:20 ` Blake Ramsdell
2007-11-02 9:30 ` Mike Hommey
2007-11-02 9:39 ` Benoit SIGOURE
2007-11-02 9:45 ` Mike Hommey
2007-11-02 10:19 ` David Symonds
2007-11-02 10:33 ` Junio C Hamano
2007-11-02 11:23 ` David Symonds
2007-11-02 20:03 ` Blake Ramsdell
2007-11-03 0:00 ` Blake Ramsdell [this message]
2007-11-03 0:07 ` [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly Junio C Hamano
2007-11-03 0:21 ` Blake Ramsdell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194048010-65955-1-git-send-email-blaker@gmail.com \
--to=blaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).