From: Shawn Bohrer <shawn.bohrer@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [RFC] Second attempt at making git-clean a builtin
Date: Sun, 4 Nov 2007 13:02:19 -0600 [thread overview]
Message-ID: <1194202941253-git-send-email-shawn.bohrer@gmail.com> (raw)
I've taken all of the comments I received from my previous attempt see:
http://marc.info/?l=git&m=119181975419521&w=2
With these new changes in place my new git-clean passes all of the
original tests as well as the new tests I've added. While looking at
how git-ls-files walks the tree there were some things that didn't quite
understand, or thought might be unnecessary so there may be some things I
missed. For example I'm still not quite sure what verify_pathspec()
does.
I did however notice what I would call a bug in the behavior of
git-ls-files and therefore the current git-clean.sh. With the current
git-clean if you have two directories that contain only untracked files,
for example docs/ and examples/ running:
git clean docs/ examples/
will not remove either directory. Instead you must use the -d
parameter. To me this makes sense, however if you run:
git clean docs/
it will remove the docs directory without using the -d parameter. My
patch is at least consistent in that it requires the -d in both cases.
next reply other threads:[~2007-11-04 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 19:02 Shawn Bohrer [this message]
2007-11-04 19:02 ` [PATCH] Add more tests for git-clean Shawn Bohrer
2007-11-04 19:02 ` [PATCH] Make git-clean a builtin Shawn Bohrer
2007-11-04 19:41 ` Pierre Habouzit
2007-11-04 20:24 ` [PATCH 3/2] Use parse-options in builtin-clean Johannes Schindelin
2007-11-04 21:16 ` Pierre Habouzit
2007-11-05 21:14 ` [PATCH] Make git-clean a builtin Junio C Hamano
2007-11-05 22:10 ` Carlos Rica
2007-11-05 23:54 ` Junio C Hamano
2007-11-06 5:05 ` Shawn Bohrer
2007-11-06 5:30 ` Junio C Hamano
2007-11-04 23:35 ` [PATCH] Add more tests for git-clean Junio C Hamano
2007-11-04 23:46 ` Pierre Habouzit
2007-11-05 0:17 ` Junio C Hamano
2007-11-04 23:49 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194202941253-git-send-email-shawn.bohrer@gmail.com \
--to=shawn.bohrer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).