git submodules and diffing

git submodules and diffing

[Sven Herzberg]

Hi,

when I started working with git submodules, I realized that git-diff  
only lists the revision ids of a submodule if it has changed. I have  
created a repository which includes a diff command for git-submodule,  
so you can use it like "gut submodule diff <modules...>"

I pushed my git tree at git://git.imendio.com/sven/git.git

Feel free to look into the changes and request improvements or merge  
it into your tree.

Regards,
   Sven

PS: Please CC me, I'm not on this list

Re: git submodules and diffing

[Jakub Narebski]

Sven Herzberg wrote:

> When I started working with git submodules, I realized that git-diff  
> only lists the revision ids of a submodule if it has changed. I have  
> created a repository which includes a diff command for git-submodule,  
> so you can use it like "gut submodule diff <modules...>"
> 
> I pushed my git tree at git://git.imendio.com/sven/git.git

I have checked it int the gitweb at
  http://git.imendio.com/?p=sven/git.git

> Feel free to look into the changes and request improvements or merge  
> it into your tree.

As far as I can see that is single patch (single commit) on top of
git.git repository, so you could have send this patch to the list,
to be commented upon.

Although having "git submodule diff" is quite nice, I'd rather have
"git diff --recurse-submodules" (or something like that) if I want to
get diff of submodules.

>From browsing commitdiff
  http://git.imendio.com/?p=sven/git.git;a=commitdiff;h=7fa1d4911d1ac2590ab1eccd84a7f235aca7878e
I'd like to mention that instead of

  (unset GIT_DIR && cd "$path" && git diff $flag "$sha1..HEAD")

you can simply use

  git --git-dir="$path" diff $flag "$sha1..HEAD"

Note that you can write "$sha1.." (but it is a bit cryptic)

> PS: Please CC me, I'm not on this list

You can always read list using NNTP / news / Usenet interface at
  nntp://news.gmane.org/gmane.comp.version-control.git
or one of the mailing list archives, see
  http://git.or.cz/gitwiki/GitCommunity

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

Re: git submodules and diffing

[Sven Herzberg]

Hey Jakub,

Am 09.11.2007 um 23:57 schrieb Jakub Narebski:

> Sven Herzberg wrote:
>
>> When I started working with git submodules, I realized that git-diff
>> only lists the revision ids of a submodule if it has changed. I have
>> created a repository which includes a diff command for git-submodule,
>> so you can use it like "gut submodule diff <modules...>"
>>
>> I pushed my git tree at git://git.imendio.com/sven/git.git

>   http://git.imendio.com/?p=sven/git.git
>
>> Feel free to look into the changes and request improvements or merge
>> it into your tree.
>
> Although having "git submodule diff" is quite nice, I'd rather have
> "git diff --recurse-submodules" (or something like that) if I want to
> get diff of submodules.

I think it's pretty nice if git-submodule is the only command that  
knows about submodules.

> From browsing commitdiff
>   http://git.imendio.com/?p=sven/ 
> git.git;a=commitdiff;h=7fa1d4911d1ac2590ab1eccd84a7f235aca7878e
> I'd like to mention that instead of
>
>   (unset GIT_DIR && cd "$path" && git diff $flag "$sha1..HEAD")
>
> you can simply use
>
>   git --git-dir="$path" diff $flag "$sha1..HEAD"

It wasn't exactly that simple (I has to add `pwd` and "/.git") but  
thats for the hint. See the updated version in my repository.

>> PS: Please CC me, I'm not on this list
>
> You can always read list using NNTP / news / Usenet interface at
>   nntp://news.gmane.org/gmane.comp.version-control.git
> or one of the mailing list archives, see
>   http://git.or.cz/gitwiki/GitCommunity

I know, but being CCed is a simple task and makes it even easier for  
me to contribute in irregular intervals.

Thank you,
   Sven