From: Ping Yin <pkufranky@gmail.com>
To: git@vger.kernel.org
Cc: Ping Yin <pkufranky@gmail.com>
Subject: [PATCH] builtin-commit: Fix git-commit honoring status.color
Date: Mon, 19 Nov 2007 01:10:34 +0800 [thread overview]
Message-ID: <1195405834-1469-1-git-send-email-pkufranky@gmail.com> (raw)
status.color shouldn't be honored when committing since the run-status
output is fed to the editor.
---
builtin-commit.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 8db74ed..4396e7d 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -45,6 +45,7 @@ static int quiet, verbose, untracked_files, no_verify;
static int no_edit, initial_commit, in_merge;
const char *only_include_assumed;
struct strbuf message;
+extern int wt_status_use_color;
static int opt_parse_m(const struct option *opt, const char *arg, int unset)
{
@@ -325,6 +326,7 @@ static int prepare_log_message(const char *index_file, const char *prefix)
if (only_include_assumed)
fprintf(fp, "# %s\n", only_include_assumed);
+ wt_status_use_color = 0;
commitable = run_status(fp, index_file, prefix);
fclose(fp);
--
1.5.3.5.1876.g7ba19-dirty
next reply other threads:[~2007-11-18 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 17:10 Ping Yin [this message]
2007-11-18 19:55 ` [PATCH] builtin-commit: Fix git-commit honoring status.color Junio C Hamano
2007-11-18 20:30 ` [PATCH] builtin-commit: run commit-msg hook with correct message file Junio C Hamano
2007-11-19 18:26 ` [PATCH] builtin-commit: Fix git-commit honoring status.color Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195405834-1469-1-git-send-email-pkufranky@gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).