git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David D. Kilzer" <ddkilzer@kilzer.net>
To: "Eric Wong" <normalperson@yhbt.net>
Cc: git@vger.kernel.org, "David D. Kilzer" <ddkilzer@kilzer.net>
Subject: [PATCH 0/3 v3] Implement git-svn info
Date: Wed, 21 Nov 2007 11:57:16 -0800	[thread overview]
Message-ID: <1195675039-26746-1-git-send-email-ddkilzer@kilzer.net> (raw)

Changes since the last patch series I posted (last night):

- Patch 1/3: No changes.
- Patch 2/3: Only changes to test code.
  - Renamed t/t9117-git-svn-info.sh to t/t9119-git-svn-info.sh.
  - Removed static expected.* files and reinstated dynamic generation.
  - Replaced "touch -c -r" with ptouch (portable/perl touch) function.
    (Should this go in t/lib-git-svn.sh?)
  - Use sed(1) inline to work around minor "svn info" vs. "git svn info"
    difference.
  - Minor test name and expected.*/actual.* file name changes.
  - Updated comments.
- Patch 3/3: Added 17 more tests (mirroring the existing 18 tests from
  Patch 2/3).

"David D. Kilzer" <ddkilzer@kilzer.net> wrote:
> "David D. Kilzer" <ddkilzer@kilzer.net> wrote:
> > Eric Wong <normalperson@yhbt.net> wrote:
> > > Can we expect the output of "svn info" to not change between
> > > versions?  I know "svn status" has changed between versions of
> > > svn.  I'd prefer if we keep the expected.* files hard-coded
> > > in a test directory and compare those instead.  Maybe use sed
> > > to substitute placeholders for timestamps..
> > Done.
> Grrr.  I remember the reason I didn't do this in the first place.
> In Patch 2/3, there are now hard-coded directory paths and my
> username in the static expected-* files.

Actually, using "svn info" to dynamically generate the results means
that the tests will break when "svn info" does change, which is a good
thing.  In other words, I think we want to know when that happens so
that we can make a decision about whether to support the change or not.

Dave

             reply	other threads:[~2007-11-21 19:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 19:57 David D. Kilzer [this message]
2007-11-21 19:57 ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions David D. Kilzer
2007-11-21 19:57   ` [PATCH 2/3 v3] git-svn info: implement info command David D. Kilzer
2007-11-21 19:57     ` [PATCH 3/3 v3] git-svn: info --url [path] David D. Kilzer
2007-11-22  1:40     ` [PATCH 2/3 v3] git-svn info: implement info command Eric Wong
2007-11-22  3:16       ` David D. Kilzer
2007-11-22  4:17         ` Eric Wong
2007-11-22  1:19   ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions Eric Wong
2007-11-22  2:23 ` [PATCH 4/3] git-svn: allow `info' command to work offline Eric Wong
2007-11-22  3:24   ` Adam Roben
2007-11-22  3:56     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195675039-26746-1-git-send-email-ddkilzer@kilzer.net \
    --to=ddkilzer@kilzer.net \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).