git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wincent Colaiuta <win@wincent.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net
Subject: Updates: teaching git-add--interactive to accept a file param
Date: Thu, 22 Nov 2007 01:02:49 +0100	[thread overview]
Message-ID: <1195689773-28601-1-git-send-email-win@wincent.com> (raw)
In-Reply-To: <C6E820C8-91E9-48B2-9219-377CA83163A7@wincent.com>

Here are some incremental updates incorporating the feedback received on the
patch series that I sent earlier today. These apply on top of the previous
patches; when this series matures I'll rebase and squash this down to a
smaller number of commits, but for the timebeing I think it's clearer if I
post these modifications separately so they can be reviewed in themselves.

The modifications are:

      Suppress spurious linefeeds in git-add--interactive
      Teach git-add--interactive to accept multiple file params
      Teach builtin-add to pass multiple paths to git-add--interactive
      Update git-add documentation for multiple interactive paths

Next step will be to follow-up on Junio's suggestion that we should support
directory paths, not just file paths, and replicate the semantics of
non-interactive git-add.

 Documentation/git-add.txt |    4 ++--
 builtin-add.c             |   23 +++++++++++++----------
 commit.h                  |    2 +-
 git-add--interactive.perl |    5 ++---
 4 files changed, 18 insertions(+), 16 deletions(-)

  reply	other threads:[~2007-11-22  0:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 12:36 [PATCH] teaching git-add--interactive to accept a file param Wincent Colaiuta
2007-11-21 12:36 ` [PATCH 1/4] Refactor patch_update_cmd Wincent Colaiuta
2007-11-21 12:36   ` [PATCH 2/4] Teach git-add--interactive to accept a file path to patch Wincent Colaiuta
2007-11-21 12:36     ` [PATCH 3/4] Teach builtin-add to pass a path argument to git-add--interactive Wincent Colaiuta
2007-11-21 12:36       ` [PATCH 4/4] Document optional file parameter " Wincent Colaiuta
2007-11-21 15:21     ` [PATCH 2/4] Teach git-add--interactive to accept a file path to patch Jeff King
2007-11-21 16:15       ` Wincent Colaiuta
2007-11-21 20:40       ` Junio C Hamano
2007-11-21 22:44         ` Wincent Colaiuta
2007-11-22  0:02           ` Wincent Colaiuta [this message]
2007-11-22  0:02             ` [PATCH 1/4] Suppress spurious linefeeds in git-add--interactive Wincent Colaiuta
2007-11-22  0:02               ` [PATCH 2/4] Teach git-add--interactive to accept multiple file params Wincent Colaiuta
2007-11-22  0:02                 ` [PATCH 3/4] Teach builtin-add to pass multiple paths to git-add--interactive Wincent Colaiuta
2007-11-22  0:02                   ` [PATCH 4/4] Update git-add documentation for multiple interactive paths Wincent Colaiuta
2007-11-22  9:08                   ` [PATCH 3/4] Teach builtin-add to pass multiple paths to git-add--interactive Jeff King
2007-11-22 10:28                     ` Wincent Colaiuta
2007-11-22 10:33                       ` Jeff King
2007-11-22 11:02                         ` Wincent Colaiuta
2007-11-22 11:37                           ` Jeff King
2007-11-22  8:59               ` [PATCH 1/4] Suppress spurious linefeeds in git-add--interactive Jeff King
2007-11-22 10:18                 ` Wincent Colaiuta
2007-11-22 10:38                   ` Junio C Hamano
2007-11-22  0:18           ` [PATCH 2/4] Teach git-add--interactive to accept a file path to patch Junio C Hamano
2007-11-22  1:36             ` [PATCH] Add path-limiting to git-add--interactive Wincent Colaiuta
2007-11-22  9:13               ` Junio C Hamano
2007-11-22  9:45                 ` Junio C Hamano
2007-11-22 11:35                   ` Wincent Colaiuta
2007-11-22 11:14                 ` Wincent Colaiuta
2007-11-22  1:41             ` [PATCH 2/4] Teach git-add--interactive to accept a file path to patch Wincent Colaiuta
2007-11-22  9:13             ` Jeff King
2007-11-22  9:50               ` Junio C Hamano
2007-11-22  9:57                 ` Jeff King
2007-11-22 10:44                 ` Wincent Colaiuta
2007-11-22 11:24                   ` Jeff King
2007-11-22 11:29                   ` Junio C Hamano
2007-11-22 11:36                     ` Jeff King
2007-11-22 13:34                     ` Wincent Colaiuta
2007-11-22 19:29                       ` Junio C Hamano
2007-11-22 21:55                         ` Wincent Colaiuta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195689773-28601-1-git-send-email-win@wincent.com \
    --to=win@wincent.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).