From: Wincent Colaiuta <win@wincent.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net
Subject: [PATCH 0/3] Updates to git-add--interactive
Date: Sun, 25 Nov 2007 14:15:39 +0100 [thread overview]
Message-ID: <1195996542-86074-1-git-send-email-win@wincent.com> (raw)
Here's an updated series, this time hopefully with the braindead
parts removed.
[PATCH 1/3] Add "--patch" option to git-add--interactive
Unchanged.
[PATCH 2/3] Move pathspec validation into interactive_add
Braindeadness removed.
[PATCH 3/3] Rename patch_update_file function to patch_update_pathspec
Only modified insofar as to make it apply on top of PATCH 2.
The one remaining issue is that pathspecs like "\*.h" don't work.
But from comments earlier on in this thread I had the impression
that they should.
They don't work because such pathspecs don't work for the underlying
git-diff-files implementation that's used by git-add--interactive:
git diff-files --numstat --summary -- \*.h
Is some alternative being proposed that would allow them to work?
next reply other threads:[~2007-11-25 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 13:15 Wincent Colaiuta [this message]
2007-11-25 13:15 ` [PATCH 1/3] Rename patch_update_file function to patch_update_pathspec Wincent Colaiuta
2007-11-25 13:15 ` [PATCH 2/3] Move pathspec validation into interactive_add Wincent Colaiuta
2007-11-25 13:15 ` [PATCH 3/3] Add "--patch" option to git-add--interactive Wincent Colaiuta
2007-11-25 18:11 ` [PATCH 1/3] Rename patch_update_file function to patch_update_pathspec Junio C Hamano
2007-11-25 18:07 ` [PATCH] builtin-add: fix command line building to call interactive Junio C Hamano
2007-11-25 18:27 ` Wincent Colaiuta
2007-11-25 18:36 ` Junio C Hamano
2007-11-25 19:02 ` Wincent Colaiuta
2007-11-25 19:48 ` Junio C Hamano
2007-11-26 4:14 ` Jeff King
2007-11-25 18:10 ` [PATCH] add -i: Fix running from a subdirectory Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2007-11-23 21:07 [PATCH v2] git-add--interactive pathspec and patch additions Junio C Hamano
2007-11-24 12:55 ` [PATCH 0/3] Updates to git-add--interactive Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195996542-86074-1-git-send-email-win@wincent.com \
--to=win@wincent.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).