From: Wincent Colaiuta <win@wincent.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, krh@redhat.com
Subject: [PATCH 0/3] builtin-commit fixes
Date: Sat, 8 Dec 2007 12:38:06 +0100 [thread overview]
Message-ID: <1197113889-16243-1-git-send-email-win@wincent.com> (raw)
A little series to bring built-in commit back in line with the
behaviour as implemented by git-commit.sh and described in the
documentation.
1/3 Allow --no-verify to bypass commit-msg hook
- git-commit.sh used to do this, but builtin-commit wasn't.
2/3 Documentation: fix --no-verify documentation for "git commit"
- The "git commit" man page should mention the commit-msg hook to
bring it in line with what's in the hook notes and in
Documentation/hooks.txt.
3/3 Fix commit-msg hook to allow editing
- Again, git-commit.sh allowed this, but builtin-commit wasn't
doing so.
I have manually tested these changes and they seem to work, but
the fact that the test suite didn't break when the behaviour of
"git commit" changed is indicative of a hole in the suite. I am
not very familiar yet with the test machinery, but I am going
to see if I can whip something up.
Cheers,
Wincent
next reply other threads:[~2007-12-08 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 11:38 Wincent Colaiuta [this message]
2007-12-08 11:38 ` [PATCH 1/3] Allow --no-verify to bypass commit-msg hook Wincent Colaiuta
2007-12-08 11:38 ` [PATCH 2/3] Documentation: fix --no-verify documentation for "git commit" Wincent Colaiuta
2007-12-08 11:38 ` [PATCH 3/3] Fix commit-msg hook to allow editing Wincent Colaiuta
2007-12-09 7:21 ` Junio C Hamano
2007-12-09 12:22 ` Wincent Colaiuta
2007-12-08 12:29 ` [PATCH 4/4] Add tests for pre-commit and commit-msg hooks Wincent Colaiuta
2007-12-08 12:51 ` Wincent Colaiuta
-- strict thread matches above, loose matches on Subject: below --
2007-11-08 12:14 [PATCH 0/3] builtin-commit fixes Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197113889-16243-1-git-send-email-win@wincent.com \
--to=win@wincent.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).