From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 4/5] Correctly initialize buffer in start_put() in http-push.c
Date: Mon, 10 Dec 2007 22:36:10 +0100 [thread overview]
Message-ID: <1197322571-25023-4-git-send-email-mh@glandium.org> (raw)
In-Reply-To: <1197322571-25023-3-git-send-email-mh@glandium.org>
Brown paper bag fix to avoid random misbehaviour.
Signed-off-by: Mike Hommey <mh@glandium.org>
---
This is a brown paper bag fix for my strbuf patch for the http code.
http-push.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c
index 2ef764c..ad8167e 100644
--- a/http-push.c
+++ b/http-push.c
@@ -495,6 +495,7 @@ static void start_put(struct transfer_request *request)
deflateInit(&stream, zlib_compression_level);
size = deflateBound(&stream, len + hdrlen);
strbuf_init(&request->buffer.buf, size);
+ request->buffer.posn = 0;
/* Compress it */
stream.next_out = (unsigned char *)request->buffer.buf.buf;
--
1.5.3.7.1159.gdd4a4
next prev parent reply other threads:[~2007-12-10 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 21:36 [PATCH 1/5] Remove the default_headers variable from http-push.c Mike Hommey
2007-12-10 21:36 ` [PATCH 2/5] Remove a CURLOPT_HTTPHEADER (un)setting Mike Hommey
2007-12-10 21:36 ` [PATCH 3/5] Avoid redundant declaration of missing_target() Mike Hommey
2007-12-10 21:36 ` Mike Hommey [this message]
2007-12-10 21:36 ` [PATCH 5/5] Fix various memory leaks in http-push.c and http-walker.c Mike Hommey
2007-12-10 23:08 ` [PATCH 6/5] Move fetch_ref from http-push.c and http-walker.c to http.c Mike Hommey
2007-12-11 5:09 ` Junio C Hamano
2007-12-11 6:21 ` Mike Hommey
2007-12-11 7:22 ` Andreas Ericsson
2007-12-11 7:49 ` Mike Hommey
2007-12-11 20:00 ` [New PATCH] " Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197322571-25023-4-git-send-email-mh@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).