From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] Brown paper bag fix to previous send-email change
Date: Tue, 11 Dec 2007 07:55:16 +0100 [thread overview]
Message-ID: <1197356116-12176-1-git-send-email-mh@glandium.org> (raw)
My previous change led to the In-Reply-To header being <> when the given
value was empty. This fixes it.
Signed-off-by: Mike Hommey <mh@glandium.org>
---
I think I have an antispam problem somewhere with this patch, because even
keeping sending it, it never reached the list. And Junio didn't answer to my
private message about it, so I guess that was some server being smart with
the subject line. *sigh*
PS: sorry Junio if you get this patch multiple time.
git-send-email.perl | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index c0e1dd3..0e8c457 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -369,8 +369,10 @@ if ($thread && !defined $initial_reply_to && $prompting) {
$initial_reply_to = $_;
}
-$initial_reply_to =~ s/^\s*<?/</;
-$initial_reply_to =~ s/>?\s*$/>/;
+if ($initial_reply_to) {
+ $initial_reply_to =~ s/^\s*<?/</;
+ $initial_reply_to =~ s/>?\s*$/>/;
+}
if (!defined $smtp_server) {
foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
--
1.5.3.7.1161.g14b8
next reply other threads:[~2007-12-11 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 6:55 Mike Hommey [this message]
2007-12-11 7:04 ` [PATCH] Brown paper bag fix to previous send-email change Junio C Hamano
2007-12-11 7:44 ` Mike Hommey
2007-12-11 8:02 ` Junio C Hamano
2007-12-11 8:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197356116-12176-1-git-send-email-mh@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).