From: "Kristian Høgsberg" <krh@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix config lockfile handling.
Date: Mon, 17 Dec 2007 11:24:43 -0500 [thread overview]
Message-ID: <1197908683.8688.0.camel@hinata.boston.redhat.com> (raw)
In-Reply-To: <7vfxy5os60.fsf@gitster.siamese.dyndns.org>
On Fri, 2007-12-14 at 13:57 -0800, Junio C Hamano wrote:
> Kristian Høgsberg <krh@redhat.com> writes:
>
> > When we commit or roll back the lock file the fd is automatically closed,
> > so don't do that again.
>
> With your change, we do not check the return status from close(2)
> anymore, which means that we may have run out of diskspace without
> noticing and renamed the incomplete file into the real place. Oops?
You're right of course. Ok, so lets just stick with the current config
file handling for 1.5.4, it's not seriously broken.
Kristian
prev parent reply other threads:[~2007-12-17 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 20:59 config.c fixes, take 2 Kristian Høgsberg
2007-12-14 20:59 ` [PATCH] Fix config lockfile handling Kristian Høgsberg
2007-12-14 20:59 ` [PATCH] Use a strbuf for building up section header and key/value pair strings Kristian Høgsberg
2007-12-14 21:57 ` [PATCH] Fix config lockfile handling Junio C Hamano
2007-12-17 16:24 ` Kristian Høgsberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197908683.8688.0.camel@hinata.boston.redhat.com \
--to=krh@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).