From: Gustaf Hendeby <hendeby@isy.liu.se>
To: gitster@pobox.com
Cc: peff@peff.net, luciano@eurotux.com, git@vger.kernel.org,
Gustaf Hendeby <hendeby@isy.liu.se>
Subject: [PATCH v3] Make git send-email accept $EDITOR with arguments
Date: Sat, 22 Dec 2007 01:40:52 +0100 [thread overview]
Message-ID: <1198284052-20590-1-git-send-email-hendeby@isy.liu.se> (raw)
In-Reply-To: <7vd4sz4uii.fsf@gitster.siamese.dyndns.org>
Currently git send-email does not accept $EDITOR with arguments, eg,
emacs -nw, when starting an editor to produce a cover letter. This
patch changes this by letting the shell handle the option parsing.
Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---
This is based on Junio's suggestion on most readable and compatible
solution. I'm not sure if it is identical to the C solution for git
tag, but it seems to be a reasonable solution.
git-send-email.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 248d035..e47994a 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -400,7 +400,7 @@ EOT
close(C);
my $editor = $ENV{GIT_EDITOR} || $repo->config("core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi";
- system($editor, $compose_filename);
+ system('sh', '-c', '$0 $@', $editor, $compose_filename);
open(C2,">",$compose_filename . ".final")
or die "Failed to open $compose_filename.final : " . $!;
--
1.5.4.rc1.16.gc817f
next prev parent reply other threads:[~2007-12-22 0:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 20:14 [PATCH] Make git send-email accept $EDITOR with arguments Gustaf Hendeby
2007-12-20 20:32 ` Luciano Rocha
2007-12-21 11:36 ` [PATCH v2] " Gustaf Hendeby
2007-12-21 13:34 ` Jeff King
2007-12-21 15:23 ` Gustaf Hendeby
2007-12-21 19:23 ` Jeff King
2007-12-21 21:07 ` Gustaf Hendeby
2007-12-21 21:17 ` Junio C Hamano
2007-12-22 0:40 ` Gustaf Hendeby [this message]
2007-12-22 1:05 ` [PATCH v3] " Junio C Hamano
2007-12-22 8:47 ` Gustaf Hendeby
2007-12-21 17:02 ` [PATCH v2] " Junio C Hamano
2007-12-22 0:43 ` [PATCH] Move git send-email cover letter temporary file to $GIT_DIR Gustaf Hendeby
2007-12-22 1:09 ` Junio C Hamano
2007-12-22 1:18 ` David Symonds
2007-12-22 6:49 ` Junio C Hamano
2007-12-22 7:04 ` David Symonds
2007-12-22 8:52 ` Junio C Hamano
2007-12-22 9:13 ` Gustaf Hendeby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198284052-20590-1-git-send-email-hendeby@isy.liu.se \
--to=hendeby@isy.liu.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luciano@eurotux.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).